Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[60629] Display messed up after creating child from relations tab in split view #17950

Conversation

HDinger
Copy link
Contributor

@HDinger HDinger commented Feb 14, 2025

Ticket

https://community.openproject.org/projects/openproject/work_packages/60629/activity

What are you trying to accomplish?

After creating a Child via the relations tab from split screen, the page layout was completely broken. This happened because we use redirect_back in the children creation controller to refresh the page that called the dialog. For whatever reason, this is however not a complete reload as the angular uiRouter is not triggered. Thus, the bodyClasses are missing and the page layout breaks.
This PR adds the bodyClasses on turbo:load which is somehow circumventing the actual problem as it is not turbo related. However, the turbo:load event is fired when redirect_back is called.

@HDinger HDinger force-pushed the bug/60629-display-messed-up-after-creating-child-from-relations-tab-in-splitted-gantt-view branch from e55e935 to f0acca9 Compare February 14, 2025 14:20
@cbliard cbliard self-requested a review February 14, 2025 14:24
Copy link
Member

@cbliard cbliard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work at the cost of an extra reload but I'm a bit too far away from frontend to tell if that's correct or not.

@HDinger
Copy link
Contributor Author

HDinger commented Feb 17, 2025

This seems to work at the cost of an extra reload but I'm a bit too far away from frontend to tell if that's correct or not.

There is no extra reload.. The turbo:load event is fired anyway. I just add classes to the body when that happens

@HDinger HDinger merged commit 0159149 into release/15.3 Feb 17, 2025
17 of 18 checks passed
@HDinger HDinger deleted the bug/60629-display-messed-up-after-creating-child-from-relations-tab-in-splitted-gantt-view branch February 17, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants