Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[61185] Replace storage deletion dialog with new DangerDialog #17836

Conversation

HDinger
Copy link
Contributor

@HDinger HDinger commented Feb 5, 2025

Ticket

https://community.openproject.org/projects/nextcloud-integration/work_packages/61185/activity

What are you trying to accomplish?

Use Primer::DangerDialog instead of FeedbackDialog for destructive actions

Copy link
Member

@Kharonus Kharonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Apparently linter is complaining, but code replacement looks good.

@HDinger HDinger force-pushed the housekeeping/61185-replace-storage-deletion-dialog-with-new-dangerdialog branch 2 times, most recently from a9d67ff to 437ccb6 Compare February 5, 2025 14:01
@HDinger HDinger force-pushed the housekeeping/61185-replace-storage-deletion-dialog-with-new-dangerdialog branch from 437ccb6 to 1c9ee50 Compare February 5, 2025 14:17
@HDinger HDinger merged commit 2e92b26 into dev Feb 5, 2025
12 checks passed
@HDinger HDinger deleted the housekeeping/61185-replace-storage-deletion-dialog-with-new-dangerdialog branch February 5, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants