Bump golang.org/x/net for CVE-2021-33194 #5058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianvf
force-pushed
the
cve-2021-33194
branch
2 times, most recently
from
797a983
to
db2e08d
Compare
openshift-ci
bot
added
the
needs-rebase
fabianvf
force-pushed
the
cve-2021-33194
branch
from
db2e08d
to
cad8311
Compare
openshift-ci
bot
removed
the
needs-rebase
|
/lgtm |
openshift-ci
bot
added
the
needs-rebase
|
@fabianvf I think we need to rebase it with master and get it merged. |
|
@fabianvf do we still need this? |
fabianvf
force-pushed
the
cve-2021-33194
branch
from
cad8311
to
d44eca5
Compare
openshift-ci
bot
removed
lgtm
|
@fabianvf it failed sanity tests. Might have to cleanup the go.sum files. |
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
fabianvf
force-pushed
the
cve-2021-33194
branch
from
d44eca5
to
851763b
Compare
|
New changes are detected. LGTM label has been removed. |
openshift-ci
bot
added
the
needs-rebase
|
@fabianvf: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@fabianvf I'm pretty sure this can be closed. This should have been fixed when we bumped to Go 1.16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Bumps golang.org/x/net dependency
Motivation for the change:
CVE-2021-33194: golang/go#46288
We shouldn't be affected by the CVE, this bump is just a precaution to prevent us from accidentally using the affected function in the future.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs