Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scorecard: use api repo v1alpha3 API, remove existing #3622

Merged
merged 1 commit into from
Jul 31, 2020
Merged

scorecard: use api repo v1alpha3 API, remove existing #3622

merged 1 commit into from
Jul 31, 2020

Conversation

estroz
Copy link
Member

@estroz estroz commented Jul 31, 2020

Description of the change: This PR removes the scorecard API from this repo, and changes import paths to the API's new location in the api repo.

  • *: update import paths
  • pkg/: remove
  • go.mod,go.sum: update api repo version to commit containing scorecard API

Motivation for the change: The scorecard API was recently moved to the api repo (operator-framework/api#55).

/cc @joelanford @jmccormick2001 @jmrodri

/area dependency

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@estroz
This commit removes the scorecard API from this repo, and changes
8f1db50 
import paths to the API's new location in the api repo.

*: update import paths

pkg/: remove

go.mod,go.sum: update api repo version to commit containing scorecard API
@openshift-ci-robot openshift-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jul 31, 2020
@joelanford joelanford mentioned this pull request Jul 31, 2020
Closed
92 tasks
joelanford
joelanford approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
fabianvf
fabianvf approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

jmrodri
jmrodri approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@estroz estroz merged commit b8a23ba into operator-framework:master Jul 31, 2020
@estroz estroz deleted the chore/scorecard-apis branch July 31, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianvf fabianvf fabianvf approved these changes

@joelanford joelanford joelanford approved these changes

@jmrodri jmrodri jmrodri approved these changes

@jmccormick2001 jmccormick2001 Awaiting requested review from jmccormick2001

Assignees

@jmrodri jmrodri

@joelanford joelanford

@fabianvf fabianvf

Labels
area/dependency Issues or PRs related to dependency changes lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@estroz @jmrodri @joelanford @fabianvf @openshift-ci-robot