Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: remove test subcommand, pkg/test, and internal e2e tests for legacy projects #3409

Merged
merged 1 commit into from
Jul 13, 2020
Merged

*: remove test subcommand, pkg/test, and internal e2e tests for legacy projects #3409

merged 1 commit into from
Jul 13, 2020

Conversation

estroz
Copy link
Member

@estroz estroz commented Jul 13, 2020

Description of the change: remove references to pkg/test, test local, and any tests that were solely based on test local.

Motivation for the change: This PR removes pkg/test, the test local subcommand, and internal SDK e2e tests from the test/test-framework sample project, as part of a larger effort to rely on unit tests, envtest, and happy path e2e testing.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@estroz estroz added this to the v1.0.0 milestone Jul 13, 2020
joelanford
joelanford approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2020
@estroz
This commit removes pkg/test, the test local subcommand, and
0fcc138 
internal SDK e2e tests from the test/test-framework sample project,
as part of a larger effort to rely on envtest.

*: remove references to pkg/test, `test local`, and any tests
that were solely based on `test local`.
@estroz estroz force-pushed the refactor/remove-test-framework branch from 5b6ff37 to 0fcc138 Compare July 13, 2020 21:18
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2020
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@estroz estroz merged commit f075c55 into operator-framework:master Jul 13, 2020
@estroz estroz deleted the refactor/remove-test-framework branch July 13, 2020 22:35
@estroz estroz mentioned this pull request Jul 13, 2020
Merged
@joelanford joelanford mentioned this pull request Jul 14, 2020
Closed
92 tasks
@camilamacedo86 camilamacedo86 mentioned this pull request Jul 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@asmacdo asmacdo Awaiting requested review from asmacdo

Assignees

@joelanford joelanford

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@estroz @openshift-ci-robot @joelanford