use go's built-in runtime arch #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
joelanford
reviewed
Nov 26, 2019
cmd/operator-sdk/build/cmd.go
Outdated
Comment on lines
94
to
96
| if value, ok := os.LookupEnv("GOARCH"); ok { | ||
| goBuildEnv = append(goBuildEnv, "GOARCH="+value) | ||
| } else { | ||
| goBuildEnv = append(goBuildEnv, "GOARCH=amd64") | ||
| } |
There was a problem hiding this comment.
This entire section can be removed. goBuildEnv is setup from the current environment int line 92, so line 95 doesn't actually do anything. Either GOARCH is already set in the environment, or it is unset, in which case go will use the default GOARCH (based on the architecture of the go binary itself).
There was a problem hiding this comment.
Also probably need a CHANGELOG update for this change.
I'm thinking a bugfix:
Updates `operator-sdk build` for go operators to compile the operator binary based on Go's built-in GOARCH detection. This fixes an issue that caused an `amd64` binary to be built into non-`amd64` base images when using operator-sdk on non-`amd64` architectures. ([#2268](https://github.com/operator-framework/operator-sdk/pull/2268))
There was a problem hiding this comment.
Updated and tested @joelanford
clnperez
force-pushed
the
build-runtime-2
branch
2 times, most recently
from
793bd9c to
ad82d47
Compare
If the user hasn't explictyly set GOARCH, don't default to amd64. This way, a user has to expliciltly cross-compile, instead of needing to know to set GOARCH on build for a native arch that isn't amd64. Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
clnperez
force-pushed
the
build-runtime-2
branch
from
ad82d47 to
7d7487c
Compare
camilamacedo86
previously approved these changes
Dec 4, 2019
There was a problem hiding this comment.
/lgtm
/approved for me as well
@joelanford can we merge this one?
camilamacedo86
added
the
approved
camilamacedo86
dismissed
their stale review
I think that I faced problem related and I'd like to test it more
joelanford
approved these changes
Dec 5, 2019
camilamacedo86
approved these changes
Dec 7, 2019
|
New changes are detected. LGTM label has been removed. |
|
Merging this one 👍 |
|
Sorry - was out on vacation. Thanks all! |
yselkowitz
pushed a commit
to yselkowitz/ocp-release-operator-sdk
that referenced
this pull request
Dec 16, 2019
If the user hasn't explictyly set GOARCH, don't default to amd64. This way, a user has to expliciltly cross-compile, instead of needing to know to set GOARCH on build for a native arch that isn't amd64. operator-framework/operator-sdk#2268 Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com> Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/ocp-release-operator-sdk
that referenced
this pull request
Dec 17, 2019
If the user hasn't explictyly set GOARCH, don't default to amd64. This way, a user has to expliciltly cross-compile, instead of needing to know to set GOARCH on build for a native arch that isn't amd64. operator-framework/operator-sdk#2268 Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com> Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/ocp-release-operator-sdk
that referenced
this pull request
Dec 18, 2019
If the user hasn't explictyly set GOARCH, don't default to amd64. This way, a user has to expliciltly cross-compile, instead of needing to know to set GOARCH on build for a native arch that isn't amd64. operator-framework/operator-sdk#2268 Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com> Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user hasn't explictyly set GOARCH, don't default to amd64. This
way, a user has to expliciltly cross-compile, instead of needing to know
to set GOARCH on build for a native arch that isn't amd64.
Signed-off-by: Christy Norman christy@linux.vnet.ibm.com
Description of the change:
See #2256
Motivation for the change:
See #2256