Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/.../genutil: verbose codegen by default #1271

Merged
merged 3 commits into from
Apr 2, 2019
Merged

cmd/.../genutil: verbose codegen by default #1271

merged 3 commits into from
Apr 2, 2019

Conversation

estroz
Copy link
Member

@estroz estroz commented Apr 1, 2019 •
edited by hasbro17
Loading

fixes #1181

Description of the change: instead of checking whether GOFLAGS="-v" is set, always print codegen errors.

Motivation for the change: better user experience.

@estroz
cmd/.../genutil: verbose codegen by default
6a9ece0 
test/e2e: remove explicit setting of verbosity
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 1, 2019
hasbro17
hasbro17 approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fixes #1181

@hasbro17
Copy link
Contributor

hasbro17 commented Apr 1, 2019

Nit: Update the CHANGELOG as well. It's a minor fix but worth pointing out.

joelanford
joelanford approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after CHANGELOG update

@hasbro17 hasbro17 added the kind/bug Categorizes issue or PR as related to a bug. label Apr 1, 2019
@hasbro17
Copy link
Contributor

hasbro17 commented Apr 1, 2019

Also can you backport this to the v0.6.x branch. Not sure if this warrants a v0.6.1 release but we should try to make sure we port our bug fixes back to the latest release branch.

@estroz estroz mentioned this pull request Apr 2, 2019
Merged
@estroz estroz merged commit a81f08f into operator-framework:master Apr 2, 2019
@estroz estroz deleted the verbose-default branch April 2, 2019 22:08
estroz added a commit that referenced this pull request Apr 2, 2019
@estroz
Backport: commands/.../generate: verbose codegen by default (#1271) (#…
f4e92a0 
…1279)

* cmd/.../genutil: verbose codegen by default

* test/e2e: remove explicit setting of verbosity

* CHANGELOG.md: add generate verbosity change
@joelanford joelanford mentioned this pull request Jun 28, 2019
Closed
@hasbro17 hasbro17 mentioned this pull request Jul 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasbro17 hasbro17 hasbro17 approved these changes

@joelanford joelanford joelanford approved these changes

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

@theishshah theishshah Awaiting requested review from theishshah

Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"generate openapi" fails with no explanation "exit status 1"
4 participants
@estroz @hasbro17 @joelanford @openshift-ci-robot