Remove legacy generate and bundle commands (#3414)

Removed legacy "generate csv/packagemanifests/bundle", and "bundle create/validate" commands.
Also removed associated scaffolding packages for these commands in "internal/generate/olm-catalog".

changelog/fragments/rm-legacy-bundle-cmds.yaml

@@ -0,0 +1,11 @@
+# entries is a list of entries to include in
+# release notes and/or the migration guide
+entries:
+  - description: >
+      Remove legacy "bundle create/validate" commands
+    kind: "removal"
+    # Is this a breaking change?
+    breaking: true
+    migration:
+      header: Remove legacy "bundle create/validate" commands
+      body: TBD

changelog/fragments/rm-legacy-gen-bundle.yaml

@@ -0,0 +1,11 @@
+# entries is a list of entries to include in
+# release notes and/or the migration guide
+entries:
+  - description: >
+      Remove legacy generate bundle command
+    kind: "removal"
+    # Is this a breaking change?
+    breaking: true
+    migration:
+      header: Remove legacy generate bundle command
+      body: TBD

changelog/fragments/rm-legacy-gen-csv.yaml

@@ -0,0 +1,11 @@
+# entries is a list of entries to include in
+# release notes and/or the migration guide
+entries:
+  - description: >
+      Remove legacy generate csv command
+    kind: "removal"
+    # Is this a breaking change?
+    breaking: true
+    migration:
+      header: Remove legacy generate csv command
+      body: TBD

changelog/fragments/rm-legacy-gen-packagemanifests.yaml

@@ -0,0 +1,11 @@
+# entries is a list of entries to include in
+# release notes and/or the migration guide
+entries:
+  - description: >
+      Remove legacy generate packagemanifests command
+    kind: "removal"
+    # Is this a breaking change?
+    breaking: true
+    migration:
+      header: Remove legacy generate packagemanifests command
+      body: TBD

cmd/operator-sdk/bundle/cmd.go

@@ -20,16 +20,11 @@ import (
 
 //nolint:structcheck
 type bundleCmd struct {
-	directory      string
-	packageName    string
-	imageTag       string
-	imageBuilder   string
-	defaultChannel string
-	channels       string
-	generateOnly   bool
+	directory    string
+	imageBuilder string
 }
 
-func newCmd() *cobra.Command {
+func NewCmd() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "bundle",
 		Short: "Manage operator bundle metadata",
@@ -39,30 +34,12 @@ native software, like the Operator Lifecycle Manager.
 
 More information about operator bundles and metadata:
 https://github.com/operator-framework/operator-registry/blob/master/docs/design/operator-bundle.md
-`,
-	}
-	return cmd
-}
 
-func NewCmdLegacy() *cobra.Command {
-	cmd := newCmd()
-	cmd.Long += `
-More information about the integration with OLM via SDK:
-https://sdk.operatorframework.io/docs/olm-integration/legacy
-`
-	cmd.AddCommand(
-		newCreateCmd(),
-		newValidateCmdLegacy(),
-	)
-	return cmd
-}
-
-func NewCmd() *cobra.Command {
-	cmd := newCmd()
-	cmd.Long += `
 More information about the integration with OLM via SDK:
 https://sdk.operatorframework.io/docs/olm-integration
-`
+`,
+	}
+
 	cmd.AddCommand(
 		newValidateCmd(),
 	)

cmd/operator-sdk/bundle/cmd_test.go

@@ -30,16 +30,4 @@ var _ = Describe("Running a bundle command", func() {
 			Expect(subcommands[0].Use).To(Equal("validate"))
 		})
 	})
-
-	Describe("NewCmdLegacy", func() {
-		It("builds and returns a cobra command with the correct subcommands", func() {
-			cmd := NewCmdLegacy()
-			Expect(cmd).NotTo(BeNil())
-
-			subcommands := cmd.Commands()
-			Expect(len(subcommands)).To(Equal(2))
-			Expect(subcommands[0].Use).To(Equal("create"))
-			Expect(subcommands[1].Use).To(Equal("validate"))
-		})
-	})
 })