Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade controller-runtime from v0.19.3 to v0.19.4 #1530

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

camilamacedo86
Copy link
Contributor

Just get bug fix

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot requested review from dinhxuanvu and oceanc80 January 10, 2025 11:00
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.80%. Comparing base (936590e) to head (1a49946).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1530   +/-   ##
=======================================
  Coverage   46.80%   46.80%           
=======================================
  Files         135      135           
  Lines       15760    15760           
=======================================
  Hits         7377     7377           
  Misses       7342     7342           
  Partials     1041     1041           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camilamacedo86 camilamacedo86 changed the title Upgrade controller-runtimr from v0.19.3 to v0.19.4 Upgrade controller-runtime from v0.19.3 to v0.19.4 Jan 10, 2025
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@perdasilva perdasilva added this pull request to the merge queue Jan 10, 2025
Merged via the queue into operator-framework:master with commit 8c2b948 Jan 10, 2025
11 of 12 checks passed
@camilamacedo86 camilamacedo86 deleted the cr-19-4 branch January 11, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants