-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graph deprecation mermaid visualization update #1172
graph deprecation mermaid visualization update #1172
Conversation
…e (bundle, channel, package) Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1172 +/- ##
==========================================
+ Coverage 53.67% 53.77% +0.10%
==========================================
Files 108 108
Lines 10340 10367 +27
==========================================
+ Hits 5550 5575 +25
- Misses 3808 3810 +2
Partials 982 982 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, everettraven, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e5dca1a
into
operator-framework:master
} | ||
} | ||
|
||
var deprecatedPackage string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this PR is merged already, but the code here presumes that we will only ever have at most one deprecated package. If the scope of the declcfg includes multiple deprecated packages, does this work?
Description of the change:
Add colorblind-friendly color indicators for deprecation of each scope (bundle, package and channel)
Motivation for the change:
Make it easy to visually identify the deprecated packages, bundles and channels from the mermaid graphs
Reviewer Checklist
/docs
Closes 1160
Previous mermaid graph output without the color indications for deprecations of each scope:
With the changes in this PR, example mermaid graph output showcasing a deprecated channel
kiali-alpha
, bundlekiali-operator.v1.68.0
, packagekiali
: