Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(doc) Add deprecated CRD version procedure and note #984

Merged
merged 1 commit into from
Sep 9, 2019
Merged

(doc) Add deprecated CRD version procedure and note #984

merged 1 commit into from
Sep 9, 2019

Conversation

dinhxuanvu
Copy link
Member

Signed-off-by: Vu Dinh vdinh@redhat.com

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 15, 2019
@dinhxuanvu dinhxuanvu force-pushed the crd-update-docs branch 3 times, most recently from e003bbc to ffaf6d1 Compare August 15, 2019 15:11
jpeeler
jpeeler reviewed Aug 15, 2019
View reviewed changes
Copy link
Contributor

@jpeeler jpeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small wording nits

Documentation/design/dependency-resolution.md Outdated Show resolved Hide resolved
Documentation/design/dependency-resolution.md Outdated Show resolved Hide resolved
@dinhxuanvu
Copy link
Member Author

Need those PRs to be merged first #973 and #983

@dinhxuanvu
Copy link
Member Author

/retest

1 similar comment
@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

2 similar comments
@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu dinhxuanvu mentioned this pull request Aug 19, 2019
Merged
@dinhxuanvu
(doc) Add deprecated CRD version procedure and note
2322eb2 
Signed-off-by: Vu Dinh <vdinh@redhat.com>
@dinhxuanvu
Copy link
Member Author

/retest

@jpeeler
Copy link
Contributor

jpeeler commented Sep 6, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, jpeeler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2019
@dinhxuanvu
Copy link
Member Author

/retest

4 similar comments
@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 5a5389c into operator-framework:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeeler jpeeler jpeeler left review comments

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

Assignees

@jpeeler jpeeler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. CRD Versioning lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dinhxuanvu @jpeeler @openshift-ci-robot @openshift-merge-robot