Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1702552: Two "NAME" fields by command "oc get catalogsource" #980

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Bug 1702552: Two "NAME" fields by command "oc get catalogsource" #980

merged 1 commit into from
Aug 22, 2019

Conversation

dinhxuanvu
Copy link
Member

The NAME field is now corrected as DISPLAY in catalogsource CRD manifest.

Signed-off-by: Vu Dinh vdinh@redhat.com

@dinhxuanvu
Bug 1702552: Two "NAME" fields by command "oc get catalogsource"
228af3e 
The NAME field is now corrected as DISPLAY in catalogsource CRD manifest.

Signed-off-by: Vu Dinh <vdinh@redhat.com>
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 8, 2019
@openshift-ci-robot
Copy link
Collaborator

@dinhxuanvu: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1702552: Two "NAME" fields by command "oc get catalogsource"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 8, 2019
@dinhxuanvu
Copy link
Member Author

/retest

ecordell
ecordell approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2019
@ecordell
Copy link
Member

/retest

1 similar comment
@dinhxuanvu
Copy link
Member Author

/retest

@jpeeler
Copy link
Contributor

jpeeler commented Aug 15, 2019

/test e2e-aws-olm

@ecordell
Copy link
Member

/retest

14 similar comments
@jpeeler
Copy link
Contributor

jpeeler commented Aug 16, 2019

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@ecordell
Copy link
Member

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

3 similar comments
@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@ecordell
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 33c4d96 into operator-framework:master Aug 22, 2019
@openshift-ci-robot
Copy link
Collaborator

@dinhxuanvu: All pull requests linked via external trackers have merged. Bugzilla bug 1702552 has been moved to the MODIFIED state.

In response to this:

Bug 1702552: Two "NAME" fields by command "oc get catalogsource"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell ecordell approved these changes

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dinhxuanvu @openshift-ci-robot @ecordell @jpeeler @openshift-merge-robot