Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1737057: Sub CRD does not validate config #978

Merged
merged 1 commit into from
Aug 26, 2019
Merged

Bug 1737057: Sub CRD does not validate config #978

merged 1 commit into from
Aug 26, 2019

Conversation

tkashem
Copy link
Collaborator

@tkashem tkashem commented Aug 6, 2019

Subscription doesn't validate the new config block. Add API
validation to Subscription CRD for Env and EnvFrom.
Use the kubernetes API specification as reference
https://raw.githubusercontent.com/kubernetes/kubernetes/master/api/openapi-spec/swagger.json

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1737057
Jira: https://jira.coreos.com/browse/OLM-1198

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 6, 2019
@tkashem
Copy link
Collaborator Author

tkashem commented Aug 6, 2019

/test unit

ecordell
ecordell approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

some of the descriptions are a little funky here, but it's probably better to keep in sync with upstream (this is what you would see if we were able to reference kube definitions directly)

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 7, 2019
@ecordell
Copy link
Member

ecordell commented Aug 7, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@ecordell: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell ecordell changed the title Bugzilla 1737057: Sub CRD does not validate config Bug 1737057: Sub CRD does not validate config Aug 7, 2019
@openshift-ci-robot
Copy link
Collaborator

@tkashem: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1737057: Sub CRD does not validate config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 7, 2019
@dinhxuanvu
Copy link
Member

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 7, 2019

/lgtm

some of the descriptions are a little funky here, but it's probably better to keep in sync with upstream (this is what you would see if we were able to reference kube definitions directly)

Yeah, I copied the description verbatim from upstream.

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 7, 2019

/retest

14 similar comments
@tkashem
Copy link
Collaborator Author

tkashem commented Aug 7, 2019

/retest

@dinhxuanvu
Copy link
Member

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 8, 2019

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 8, 2019

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 8, 2019

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 8, 2019

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 9, 2019

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 9, 2019

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 9, 2019

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 10, 2019

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 10, 2019

/retest

@ecordell
Copy link
Member

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 12, 2019

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 12, 2019

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 15, 2019

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 15, 2019

/refresh

@jpeeler
Copy link
Contributor

jpeeler commented Aug 15, 2019

/test e2e-aws

@ecordell
Copy link
Member

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2019
@jpeeler
Copy link
Contributor

jpeeler commented Aug 16, 2019

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2019
@tkashem
Copy link
Collaborator Author

tkashem commented Aug 18, 2019

/retest

2 similar comments
@tkashem
Copy link
Collaborator Author

tkashem commented Aug 19, 2019

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 19, 2019

/retest

@tkashem
Bugzilla 1737057: Sub CRD does not validate config
f0436eb 
Subscription doesn't validate the new `config` block. Add API
validation to Subscription CRD for `Env` and `EnvFrom`.
Use the kubernetes API specification as reference
https://raw.githubusercontent.com/kubernetes/kubernetes/master/api/openapi-spec/swagger.json

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1737057
Jira: https://jira.coreos.com/browse/OLM-1198
@ecordell
Copy link
Member

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, jpeeler, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 22, 2019

/retest

4 similar comments
@tkashem
Copy link
Collaborator Author

tkashem commented Aug 22, 2019

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 22, 2019

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 22, 2019

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 22, 2019

/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 23, 2019

/test unit

1 similar comment
@tkashem
Copy link
Collaborator Author

tkashem commented Aug 26, 2019

/test unit

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 26, 2019

/refresh
/retest

@tkashem
Copy link
Collaborator Author

tkashem commented Aug 26, 2019

/test e2e-aws-console-olm

@openshift-merge-robot openshift-merge-robot merged commit a621296 into operator-framework:master Aug 26, 2019
@openshift-ci-robot
Copy link
Collaborator

@tkashem: All pull requests linked via external trackers have merged. Bugzilla bug 1737057 has been moved to the MODIFIED state.

In response to this:

Bug 1737057: Sub CRD does not validate config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell ecordell approved these changes

@njhale njhale Awaiting requested review from njhale

Assignees

@ecordell ecordell

@jpeeler jpeeler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tkashem @ecordell @openshift-ci-robot @dinhxuanvu @jpeeler @openshift-merge-robot