-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1737057: Sub CRD does not validate config #978
Bug 1737057: Sub CRD does not validate config #978
Conversation
/test unit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
some of the descriptions are a little funky here, but it's probably better to keep in sync with upstream (this is what you would see if we were able to reference kube definitions directly)
/bugzilla refresh |
@ecordell: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tkashem: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
Yeah, I copied the description verbatim from upstream. |
/retest |
14 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/refresh |
/test e2e-aws |
/retest |
/retest |
/retest |
2 similar comments
/retest |
/retest |
Subscription doesn't validate the new `config` block. Add API validation to Subscription CRD for `Env` and `EnvFrom`. Use the kubernetes API specification as reference https://raw.githubusercontent.com/kubernetes/kubernetes/master/api/openapi-spec/swagger.json BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1737057 Jira: https://jira.coreos.com/browse/OLM-1198
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, jpeeler, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
/test unit |
1 similar comment
/test unit |
/refresh |
/test e2e-aws-console-olm |
@tkashem: All pull requests linked via external trackers have merged. Bugzilla bug 1737057 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Subscription doesn't validate the new
config
block. Add APIvalidation to Subscription CRD for
Env
andEnvFrom
.Use the kubernetes API specification as reference
https://raw.githubusercontent.com/kubernetes/kubernetes/master/api/openapi-spec/swagger.json
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1737057
Jira: https://jira.coreos.com/browse/OLM-1198