Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(doc) update new release doc #968

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

tkashem
Copy link
Collaborator

@tkashem tkashem commented Jul 26, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 26, 2019
@tkashem tkashem changed the title (doc) update make new release doc (doc) update new release doc Jul 26, 2019

If you see change(s) in `manifests` folder, then:
* STOP the release process
* Consult the team and backport the changes in `manifests` folder into the templates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa - have people been putting changes into the manifests without using the templates? I assumed that when this happened the templates were modified and no make release was done.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything went fine for me, I just added it as a precaution. :)

@tkashem
Copy link
Collaborator Author

tkashem commented Jul 26, 2019

/retest

Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for making this clearer!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2019
@tkashem
Copy link
Collaborator Author

tkashem commented Jul 26, 2019

Thanks for making this clearer!

I must thank @dinhxuanvu, he helped me with the release and gave me the idea to update the readme :)

@dinhxuanvu
Copy link
Member

/retest

1 similar comment
@tkashem
Copy link
Collaborator Author

tkashem commented Jul 29, 2019

/retest

@openshift-ci-robot
Copy link
Collaborator

@tkashem: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-olm 0e8705c link /test e2e-aws-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ecordell ecordell merged commit 97b62e9 into operator-framework:master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants