Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(proposal) improved csv status reporting #939

Merged
merged 1 commit into from
Aug 21, 2019
Merged

(proposal) improved csv status reporting #939

merged 1 commit into from
Aug 21, 2019

Conversation

tkashem
Copy link
Collaborator

@tkashem tkashem commented Jul 1, 2019

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 1, 2019
@tkashem
Copy link
Collaborator Author

tkashem commented Jul 1, 2019

/retest

@openshift-ci-robot
Copy link
Collaborator

@tkashem: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/unit d7a9d57 link /test unit
ci/prow/e2e-aws-olm d7a9d57 link /test e2e-aws-olm
ci/prow/e2e-aws-upgrade d7a9d57 link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ecordell
Copy link
Member

/lgtm

This is a good starting point for conditions for CSVs. When we get to implementing this we can bikeshed about the actual fields/etc 😄

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2019
@ecordell ecordell merged commit e1ca813 into operator-framework:master Aug 21, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@ecordell ecordell Awaiting requested review from ecordell

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. proposal size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tkashem @openshift-ci-robot @ecordell @njhale