Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.1] Bug 1755646: Cleanup leftover cross-namespace OwnerReferences #1049

Merged
merged 2 commits into from
Oct 1, 2019
Merged

[release-4.1] Bug 1755646: Cleanup leftover cross-namespace OwnerReferences #1049

merged 2 commits into from
Oct 1, 2019

Conversation

njhale
Copy link
Member

@njhale njhale commented Sep 25, 2019

Description of the change:

Backport #1025 to release-4.1

Motivation for the change:

#1025 ensures this cleanup occurs on upgrade between 4.1.z and 4.2.Z, but doesn't handle 4.1.z to 4.1.z'.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@njhale
fix(init): cleanup leftover cross-namespace ownerreferences
5557e59 
Cleanup leftover cross-namespace OwnerReferences and delete existing packageserver Subscription to trigger a reinstall via CVO.
@openshift-ci-robot
Copy link
Collaborator

@njhale: This pull request references Bugzilla bug 1746159, which is invalid:

  • expected the bug to target the "4.1.z" release, but it targets "4.2.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.1] Bug 1746159: Cleanup leftover cross-namespace OwnerReferences

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 25, 2019
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 25, 2019
@njhale njhale changed the title [release-4.1] Bug 1746159: Cleanup leftover cross-namespace OwnerReferences [release-4.1] Bug 1755646: Cleanup leftover cross-namespace OwnerReferences Sep 25, 2019
@openshift-ci-robot
Copy link
Collaborator

@njhale: This pull request references Bugzilla bug 1755646, which is invalid:

  • expected the bug to target the "4.1.z" release, but it targets "4.2.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.1] Bug 1755646: Cleanup leftover cross-namespace OwnerReferences

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@njhale
Copy link
Member Author

njhale commented Sep 25, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@njhale: This pull request references Bugzilla bug 1755646, which is invalid:

  • expected the bug to target the "4.1.z" release, but it targets "4.2.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@njhale
Copy link
Member Author

njhale commented Sep 26, 2019

/bugzilla refresh
/retest

@openshift-ci-robot
Copy link
Collaborator

@njhale: This pull request references Bugzilla bug 1755646, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 26, 2019
@ecordell
Copy link
Member

/retest

1 similar comment
@njhale
Copy link
Member Author

njhale commented Sep 26, 2019

/retest

@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2019
@shawn-hurley shawn-hurley added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 27, 2019
@njhale
Copy link
Member Author

njhale commented Sep 27, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2019
@shawn-hurley shawn-hurley removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 27, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2019
@njhale
Copy link
Member Author

njhale commented Sep 27, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2019
@njhale
Copy link
Member Author

njhale commented Sep 27, 2019

/test ci/prow/e2e-aws-olm

@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@njhale
Copy link
Member Author

njhale commented Sep 29, 2019

/test ci/prow/e2e-aws-olm

@ecordell
Copy link
Member

I verified this on 4.1.z:

  • Installed a cluster with this change
  • Deleted the packageserver serviceaccount
  • Saw the packageserver go unhealthy
  • Killed olm and catalog operators
  • CVO recreated OLM and Catalog operators
  • packageserver serviceaccount came back
  • packageserver came back

@shawn-hurley shawn-hurley added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 30, 2019
@dinhxuanvu
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit d7e24ee into operator-framework:release-4.1 Oct 1, 2019
@openshift-ci-robot
Copy link
Collaborator

@njhale: All pull requests linked via external trackers have merged. Bugzilla bug 1755646 has been moved to the MODIFIED state.

In response to this:

[release-4.1] Bug 1755646: Cleanup leftover cross-namespace OwnerReferences

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@njhale njhale deleted the clean-orefs-4.1 branch March 31, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@jpeeler jpeeler Awaiting requested review from jpeeler

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@njhale @openshift-ci-robot @ecordell @dinhxuanvu @shawn-hurley @openshift-merge-robot