Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.1] Bug 1753394: include git sha in ART builds #1044

Merged
merged 1 commit into from
Sep 27, 2019
Merged

[release-4.1] Bug 1753394: include git sha in ART builds #1044

merged 1 commit into from
Sep 27, 2019

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #961

/assign ecordell

@tkashem
bz-1662263: include git sha in ART builds
06032fe 
ART sets SOURCE_GIT_COMMIT env variable in Dockerfile at build time.
- If SOURCE_GIT_COMMIT is set use its value, otherwise get the
  commit sha from current HEAD.

https://jira.coreos.com/browse/OLM-1182
https://bugzilla.redhat.com/show_bug.cgi?id=1662263
https://jira.coreos.com/browse/ART-460
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 21, 2019
Merged
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 21, 2019
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1662263, which is invalid:

  • expected the bug to target the "4.1.z" release, but it targets "4.2.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.1] Bug 1662263: include git sha in ART builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 21, 2019
@ecordell ecordell changed the title [release-4.1] Bug 1662263: include git sha in ART builds [release-4.1] Bug 1753394: include git sha in ART builds Sep 21, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 21, 2019
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1753394, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

[release-4.1] Bug 1753394: include git sha in ART builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 21, 2019
@ecordell
Copy link
Member

/retest

@ecordell
Copy link
Member

/assign @tkashem

@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2019
@shawn-hurley shawn-hurley added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 27, 2019
@ecordell
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit dacfea7 into operator-framework:release-4.1 Sep 27, 2019
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1753394 has been moved to the MODIFIED state.

In response to this:

[release-4.1] Bug 1753394: include git sha in ART builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@jpeeler jpeeler Awaiting requested review from jpeeler

Assignees

@ecordell ecordell

@tkashem tkashem

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @ecordell @shawn-hurley @tkashem @openshift-merge-robot