Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1748771: Default Icon for PackageManifest Subresource #1026

Conversation

alecmerdler
Copy link
Member

@alecmerdler alecmerdler commented Sep 4, 2019

Description

Instead of returning HTTP 404, the packagemanifests/icon subresource will return the default icon.

Screenshots

Default icon in OperatorHub:
Screenshot_20190904_124934

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1748771

@openshift-ci-robot
Copy link
Collaborator

@alecmerdler: An error was encountered searching for bug 1748771 on the Bugzilla server at https://bugzilla.redhat.com:

Get https://bugzilla.redhat.com/rest/bug/1748771?api_key=CENSORED: dial tcp: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1748771: Default Icon for PackageManifest Subresource

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 4, 2019
@openshift-ci-robot
Copy link
Collaborator

@alecmerdler: This pull request references Bugzilla bug 1748771, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1748771: Default Icon for PackageManifest Subresource

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 4, 2019
@ecordell
Copy link
Member

ecordell commented Sep 4, 2019

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alecmerdler,ecordell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f3bdafc into operator-framework:master Sep 5, 2019
@openshift-ci-robot
Copy link
Collaborator

@alecmerdler: All pull requests linked via external trackers have merged. Bugzilla bug 1748771 has been moved to the MODIFIED state.

In response to this:

Bug 1748771: Default Icon for PackageManifest Subresource

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alecmerdler alecmerdler deleted the bugzilla-1748771 branch September 5, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants