-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1717636: Add proper name to related objects #1018
Bug 1717636: Add proper name to related objects #1018
Conversation
@jpeeler: This pull request references Bugzilla bug 1717636, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d5c3af9
to
2f148e0
Compare
@jpeeler: This pull request references Bugzilla bug 1717636, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/lgtm This seems like a pretty reasonable way to keep the related objects up-to-date. I think ideally it would be done by keeping a cache up to date with a watch (instead of polling with |
/hold |
2f148e0
to
0abbed2
Compare
0abbed2
to
c799a51
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@jpeeler: All pull requests linked via external trackers have merged. Bugzilla bug 1717636 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is take 2. Would be nice to confirm that the related objects sections are totally correct. The catalog operator is not showing any subscriptions or installplans in the openshift-marketplace project because none have been created yet.
Also resolves https://bugzilla.redhat.com/show_bug.cgi?id=1717638.