Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1717636: Add proper name to related objects #1018

Conversation

jpeeler
Copy link
Contributor

@jpeeler jpeeler commented Aug 29, 2019

This is take 2. Would be nice to confirm that the related objects sections are totally correct. The catalog operator is not showing any subscriptions or installplans in the openshift-marketplace project because none have been created yet.

Also resolves https://bugzilla.redhat.com/show_bug.cgi?id=1717638.

apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
  creationTimestamp: 2019-08-30T21:18:05Z
  generation: 1
  name: operator-lifecycle-manager
  resourceVersion: "12313"
  selfLink: /apis/config.openshift.io/v1/clusteroperators/operator-lifecycle-manager
  uid: a8509a0e-cb6b-11e9-8b44-123338630872
spec: {}
status:
  conditions:
  - lastTransitionTime: 2019-08-30T21:18:05Z
    status: "False"
    type: Degraded
  - lastTransitionTime: 2019-08-30T21:23:10Z
    message: Deployed 0.11.0
    status: "False"
    type: Progressing
  - lastTransitionTime: 2019-08-30T21:18:05Z
    status: "True"
    type: Available
  - lastTransitionTime: 2019-08-30T21:18:05Z
    status: "True"
    type: Upgradeable
  extension: null
  relatedObjects:
  - group: ""
    name: operator-lifecycle-manager
    resource: namespaces
  versions:
  - name: operator
    version: 0.0.1-2019-08-30-210019
  - name: operator-lifecycle-manager
    version: 0.11.0
apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
  creationTimestamp: 2019-08-30T21:18:29Z
  generation: 1
  name: operator-lifecycle-manager-catalog
  resourceVersion: "12638"
  selfLink: /apis/config.openshift.io/v1/clusteroperators/operator-lifecycle-manager-catalog
  uid: b64fc99d-cb6b-11e9-8b44-123338630872
spec: {}
status:
  conditions:
  - lastTransitionTime: 2019-08-30T21:18:29Z
    status: "False"
    type: Degraded
  - lastTransitionTime: 2019-08-30T21:23:34Z
    message: Deployed 0.11.0
    status: "False"
    type: Progressing
  - lastTransitionTime: 2019-08-30T21:18:29Z
    status: "True"
    type: Available
  - lastTransitionTime: 2019-08-30T21:18:29Z
    status: "True"
    type: Upgradeable
  extension: null
  relatedObjects:
  - group: ""
    name: operator-lifecycle-manager
    resource: namespaces
  versions:
  - name: operator
    version: 0.0.1-2019-08-30-210019
  - name: operator-lifecycle-manager
    version: 0.11.0
apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
  creationTimestamp: 2019-08-30T21:18:05Z
  generation: 1
  name: operator-lifecycle-manager-packageserver
  resourceVersion: "8182"
  selfLink: /apis/config.openshift.io/v1/clusteroperators/operator-lifecycle-manager-packageserver
  uid: a84f41b8-cb6b-11e9-8b44-123338630872
spec: {}
status:
  conditions:
  - lastTransitionTime: 2019-08-30T21:18:05Z
    status: "False"
    type: Degraded
  - lastTransitionTime: 2019-08-30T21:20:45Z
    status: "True"
    type: Available
  - lastTransitionTime: 2019-08-30T21:20:45Z
    message: Deployed version 0.11.0
    status: "False"
    type: Progressing
  - lastTransitionTime: 2019-08-30T21:18:05Z
    message: Safe to upgrade
    status: "True"
    type: Upgradeable
  extension: null
  relatedObjects:
  - group: ""
    name: openshift-operator-lifecycle-manager
    resource: namespaces
  - group: operators.coreos.com
    name: packageserver
    namespace: openshift-operator-lifecycle-manager
    resource: ClusterServiceVersion
  versions:
  - name: operator
    version: 0.0.1-2019-08-30-210019
  - name: packageserver
    version: 0.11.0

@openshift-ci-robot
Copy link
Collaborator

@jpeeler: This pull request references Bugzilla bug 1717636, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1717636: Add fields related objects 2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 29, 2019
@jpeeler jpeeler changed the title Bug 1717636: Add fields related objects 2 Bug 1717636: Add proper name to related objects Aug 29, 2019
@jpeeler jpeeler force-pushed the add-fields-related-objects-2 branch 2 times, most recently from d5c3af9 to 2f148e0 Compare August 30, 2019 20:47
@openshift-ci-robot
Copy link
Collaborator

@jpeeler: This pull request references Bugzilla bug 1717636, which is valid.

In response to this:

Bug 1717636: Add proper name to related objects

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jpeeler
Copy link
Contributor Author

jpeeler commented Sep 3, 2019

/retest

@ecordell
Copy link
Member

ecordell commented Sep 4, 2019

/lgtm

This seems like a pretty reasonable way to keep the related objects up-to-date. I think ideally it would be done by keeping a cache up to date with a watch (instead of polling with list), but since this should only query the one namespace every 5s it seems fine.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2019
@dinhxuanvu
Copy link
Member

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2019
pkg/lib/operatorstatus/status.go Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2019
@jpeeler
Copy link
Contributor Author

jpeeler commented Sep 4, 2019

/retest

@ecordell
Copy link
Member

ecordell commented Sep 4, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, jpeeler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dinhxuanvu
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2019
@openshift-merge-robot openshift-merge-robot merged commit 39a378f into operator-framework:master Sep 4, 2019
@openshift-ci-robot
Copy link
Collaborator

@jpeeler: All pull requests linked via external trackers have merged. Bugzilla bug 1717636 has been moved to the MODIFIED state.

In response to this:

Bug 1717636: Add proper name to related objects

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants