Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access from a PWA (CORS headers) #522

Closed
alensiljak opened this issue Jan 8, 2024 · 4 comments
Closed

Allow access from a PWA (CORS headers) #522

alensiljak opened this issue Jan 8, 2024 · 4 comments
Assignees
Labels
enhancement Enhancement of an existing feature
Milestone

Comments

@alensiljak
Copy link

Discussion: https://openziti.discourse.group/t/webdav-with-cors/1967

I'd like to be able to use WebDAV interface from a Progressive Web Application (PWA) but that will require explicitly allowing access via CORS headers on the server side. Additionally, it will also require explicitly allowing the WebDAV headers when CORS is active.
Just recently added this to rclone, so hopefully this helps: rclone/rclone#7495

Basically, origin, methods, and headers need to be specified for WebDAV access. Origin for web.

Resources:

@michaelquigley michaelquigley added the enhancement Enhancement of an existing feature label Jan 8, 2024
@michaelquigley michaelquigley added this to the v0.4 milestone Jan 8, 2024
@michaelquigley
Copy link
Collaborator

michaelquigley commented Jan 17, 2024

I think I remember a discourse thread talking about this where this request was described as needed to apply to a single, private zrok access private, rather than to the public frontend. Can we confirm the scope of this feature request?

Adding this capability to a single zrok access private instance is an order of magnitude simpler than making it available on a large, shared, public frontend.

Considering Ziti provides a tunnel, I would mostly recommend using this in private mode

@alensiljak
Copy link
Author

At the moment, I would use this in private mode as it is much safer and satisfies my use case completely.
Should different needs arise, it would then be easier to provide more detailed requirements based on a real use case rather than hypothetically.
Thank you!

@michaelquigley
Copy link
Collaborator

Fair enough. Will backlog this to get knocked out within zrok access private fairly soon.

@michaelquigley michaelquigley moved this from Backlog to Development in zrok Development Roadmap Aug 6, 2024
@michaelquigley michaelquigley self-assigned this Aug 6, 2024
michaelquigley added a commit that referenced this issue Aug 7, 2024
@michaelquigley
Copy link
Collaborator

In v0.4.39 the zrok access private command has a new flag (--response-header), which allows for adding arbitrary HTTP headers to the response for HTTP-based backend modes. This should cover this scenario, along with other uses.

michaelquigley added a commit that referenced this issue Aug 7, 2024
Add Response Header Flag to zrok access private (#522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of an existing feature
Projects
Development

No branches or pull requests

2 participants