Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-jose. Fixes #607 #608

Closed
wants to merge 1 commit into from
Closed

Update go-jose. Fixes #607 #608

wants to merge 1 commit into from

Conversation

plorenz
Copy link
Member

@plorenz plorenz commented Aug 2, 2024

No description provided.

@plorenz plorenz requested a review from a team as a code owner August 2, 2024 19:57
Comment on lines +89 to 90
gopkg.in/go-jose/go-jose.v2 v2.6.3 // indirect
gopkg.in/square/go-jose.v2 v2.6.0 // indirect
Copy link
Member

@andrewpmartinez andrewpmartinez Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two different module paths, /square vs. /go-jose are present. Does this even fix the issue? Any Code that uses the other path will still use the vulnerable code, no?

There seems to be a repo migration issue here. The original GitHub repo moved and it appears that gopk.in uses the older repo as a source.

I think the only way to address this in the SDK and controller is to get the downstream repo to fix its module reference.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I pulled the branch and looked at the deptree from this project and the only go-jose tree I see is from zitadel so if 2.6.3 has the vulnerability fixed, it seems to me that this would resolve the issue here

@plorenz
Copy link
Member Author

plorenz commented Aug 4, 2024

@andrewpmartinez is working on getting the library updated in zitiadel.

@plorenz plorenz closed this Aug 4, 2024
@plorenz plorenz deleted the update-go-jose branch September 5, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants