docker: works around zipkin-rabbitmq arm64 build fail in GHA deploy #3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the docker deployment is failing on zipkin-rabbitmq on arm64.
This isn't reproducable locally on either amd64 of arm64, but basically
the rabbitmq-server crashes Dockerfile in an invalid way when building
arm64:
```
BOOT FAILED
===========
Error during startup: {error,
{incompatible_feature_flags,
{disabled_required_feature_flag,
classic_mirrored_queue_version}}}
```
What's invalid is that the same build which includes those features
works outside the GHA runner. After spending a good bit of time on this,
I gave up. Maybe a later version of qemu will sort it out.
Meanwhile, I switched the parent layer to the official docker image, and
also switched to a configuration approach to define the default queue. I
also noticed we have a bug in our collector logic where rabbit must be
running prior to zipkin starting. This is a bug and I'll fix it later,
but meanwhile it can be worked around with a dependency order in the
example docker-compose file.
Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
changed the title
codefromthecrypt
changed the title
|
opened an issue on the unrelated ci flake #3633 |
anuraaga
approved these changes
Dec 13, 2023
|
Thanks for the offline advice @anuraaga! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the docker deployment is failing on zipkin-rabbitmq on arm64. This isn't reproducable locally on either amd64 of arm64, but basically the rabbitmq-server crashes Dockerfile in an invalid way when building arm64:
What's invalid is that the same build which includes those features works outside the GHA runner. After spending a good bit of time on this, I gave up. Maybe a later version of qemu will sort it out.
Meanwhile, I switched the parent layer to the official docker image, and also switched to a configuration approach to define the default queue. I also noticed we have a bug in our collector logic where rabbit must be running prior to zipkin starting. This is a bug and I'll fix it later, but meanwhile it can be worked around with a dependency order in the example docker-compose file.