Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routine dependency updates #271

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Routine dependency updates #271

merged 1 commit into from
Sep 10, 2024

Conversation

reta
Copy link
Contributor

@reta reta commented Sep 9, 2024

Routine dependency updates

@reta reta mentioned this pull request Sep 9, 2024
Merged
@reta
Routine dependency updates
bc61a7b 
Signed-off-by: Andriy Redko <drreta@gmail.com>
codefromthecrypt
codefromthecrypt approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again! wanna do the honors of pushing the release tag?

@codefromthecrypt codefromthecrypt merged commit ad5b40f into openzipkin:master Sep 10, 2024
3 checks passed
@reta
Copy link
Contributor Author

reta commented Sep 10, 2024

thanks again! wanna do the honors of pushing the release tag?

Tag pushed [1], release updated! Thanks folks!

[1] https://github.com/openzipkin/zipkin-reporter-java/releases/tag/3.4.1

@shakuzen
Copy link
Member

It looks like deploying the bom was successful but the jars failed: https://github.com/openzipkin/zipkin-reporter-java/actions/runs/10792310306
Can we re-run the job or do we need to manually do something to finish the release?

@codefromthecrypt
Copy link
Member

smells like a sonatype timeout. maybe double-check they didn't make it to central. If not, double check with the sonatype oss login. regardless, running again shouldn't hurt as maven prevents double-uploading server-side

p.s. I noticed they changed since I last looked to require an email instead of a username login https://ossindex.sonatype.org/user/signin

@shakuzen
Copy link
Member

It looks like none of the jars made it to central (dependabot PR to upgrade is failing to find any of the jars). I've re-run the deploy jars job now and it was successful. Things should be in central soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

@shakuzen shakuzen shakuzen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reta @shakuzen @codefromthecrypt