make http client configurable, closes #30 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llinder wonder if you can take a look |
llinder
requested changes
Aug 24, 2019
There was a problem hiding this comment.
Looks good. Only thing I would like is to avoid the Ratpack version change if possible.
@jeff-blaisdell @Bijnagte might also be interested or have input on the Guice bindings.
pom.xml
Outdated
| @@ -50,7 +50,7 @@ | |||
| <license-maven-plugin.version>3.0</license-maven-plugin.version> | |||
|
|
|||
| <brave.version>5.6.3</brave.version> | |||
| <ratpack.version>1.6.0</ratpack.version> | |||
There was a problem hiding this comment.
Is there a reason to bump the version? We still have a number of services that may be using Ratpack 1.6 and accidentally importing a new version may cause problems.
|
@llinder reverted to 1.6.0 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.