Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --logging parameter of browsertrix crawler #274

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Jan 23, 2024

Fix #273

Nota:

  • we now have intentionally two distinct flags:
    • --logging for browsertrix crawler
    • --verbose for warc2zim
  • this is targeting zimit2 branch because there is no urgency to release this and I don't want to have again the same commit in two distinct branches

While this is obviously a tradeoff, having two parameters allow to make more verbose only the tool that interest us.

@benoit74 benoit74 self-assigned this Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c7fdc1d) 15.60% compared to head (a505df9) 15.53%.
Report is 1 commits behind head on zimit2.

Files Patch % Lines
src/zimit/zimit.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           zimit2     #274      +/-   ##
==========================================
- Coverage   15.60%   15.53%   -0.07%     
==========================================
  Files           1        1              
  Lines         250      251       +1     
  Branches       39       39              
==========================================
  Hits           39       39              
- Misses        211      212       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review January 23, 2024 16:43
@benoit74 benoit74 requested a review from rgaudin January 23, 2024 16:43
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; good enough for now

@benoit74 benoit74 merged commit f435902 into zimit2 Jan 25, 2024
4 of 6 checks passed
@benoit74 benoit74 deleted the add_logging branch January 25, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants