Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix secrets removal in UI + add support for long-description in kolibri #808

Merged
merged 5 commits into from
Aug 14, 2023
Merged

Fix secrets removal in UI + add support for long-description in kolibri #808

merged 5 commits into from
Aug 14, 2023

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Jul 27, 2023 •
edited
Loading

Rationale

Fix #805

Fix #803

Changes

  • added support for --long-description CLI parameter for kolibri
  • fixed the removal of secret in commands to support more cases
    • flags where OK
    • issue was linked to the fact tasks are returning command with param=secret_value instead of param="secret_value"
    • secret removal now supports commands with param="secret_value" (as before) but also (new) param=secret_value and param='secret_value'
    • tests have been added accordingly to exercise these "new" situations
    • no issue related to authenticated users has been observed, they have access to the plain secret value

@benoit74 benoit74 marked this pull request as ready for review July 27, 2023 15:05
@benoit74 benoit74 requested a review from rgaudin July 27, 2023 15:08
rgaudin
rgaudin requested changes Jul 27, 2023
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure 🤔

dispatcher/backend/src/common/schemas/offliners/kolibri.py Show resolved Hide resolved
dispatcher/backend/src/routes/utils.py Show resolved Hide resolved
@rgaudin
Copy link
Member

rgaudin commented Jul 27, 2023

An please edit the PR name

@benoit74 benoit74 changed the title Small fixes Fix secrets removal in UI + add support for long-description in kolibri Aug 14, 2023
@benoit74 benoit74 requested a review from rgaudin August 14, 2023 06:59
rgaudin
rgaudin approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit 1e5a95e into main Aug 14, 2023
5 checks passed
@benoit74 benoit74 deleted the small_fixes branch August 14, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for --long-description parameter for kolibri Secrets are still not hided properly
2 participants
@benoit74 @rgaudin