Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case-insensitive comparator for extMimeTypes. #458

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ThisIsFineTM
Copy link
Contributor

This introduces a case-insensitive lexicographical comparator for the mimetype map in zimwriterfs/tools. This allows us to remove the duplicate entries in the mime type map.

Closes #457.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.86%. Comparing base (3ad99a1) to head (1365faa).

Files with missing lines Patch % Lines
src/zimwriterfs/tools.cpp 88.88% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   27.70%   28.86%   +1.16%     
==========================================
  Files          26       26              
  Lines        2534     2477      -57     
  Branches     1363     1297      -66     
==========================================
+ Hits          702      715      +13     
  Misses       1325     1325              
+ Partials      507      437      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case-insensitive comparator for mimetype map
1 participant