Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies, including zimscraperlib 4 #306

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Sep 3, 2024

Most commits have been suggested by dependabot, I just rebased them in on single branch and added needed adaptations in few additional commits.

Nota: eslint has been rolled-back to 8.57.0, because upgrade to 9 is huge and I failed to make it work properly (same problem encountered on zimit-frontend, looks like Vue.JS + typescript within Vue.JS files is not a common combination in eslint users ...)

dependabot bot and others added 4 commits September 3, 2024 07:19
Bumps the production-dependencies group in /zimui with 8 updates:

| Package | From | To |
| --- | --- | --- |
| [@fontsource/roboto](https://github.com/fontsource/font-files/tree/HEAD/fonts/google/roboto) | `5.0.13` | `5.0.14` |
| [axios](https://github.com/axios/axios) | `1.7.4` | `1.7.7` |
| [dayjs](https://github.com/iamkun/dayjs) | `1.11.11` | `1.11.13` |
| [pinia](https://github.com/vuejs/pinia) | `2.1.7` | `2.2.2` |
| [vite-plugin-vuetify](https://github.com/vuetifyjs/vuetify-loader) | `2.0.3` | `2.0.4` |
| [vue](https://github.com/vuejs/core) | `3.4.27` | `3.4.38` |
| [vue-router](https://github.com/vuejs/router) | `4.3.2` | `4.4.3` |
| [vuetify](https://github.com/vuetifyjs/vuetify/tree/HEAD/packages/vuetify) | `3.6.7` | `3.7.1` |


Updates `@fontsource/roboto` from 5.0.13 to 5.0.14
- [Changelog](https://github.com/fontsource/font-files/blob/main/fonts/google/roboto/CHANGELOG.md)
- [Commits](https://github.com/fontsource/font-files/commits/HEAD/fonts/google/roboto)

Updates `axios` from 1.7.4 to 1.7.7
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.7.4...v1.7.7)

Updates `dayjs` from 1.11.11 to 1.11.13
- [Release notes](https://github.com/iamkun/dayjs/releases)
- [Changelog](https://github.com/iamkun/dayjs/blob/v1.11.13/CHANGELOG.md)
- [Commits](iamkun/dayjs@v1.11.11...v1.11.13)

Updates `pinia` from 2.1.7 to 2.2.2
- [Release notes](https://github.com/vuejs/pinia/releases)
- [Commits](https://github.com/vuejs/pinia/compare/pinia@2.1.7...pinia@2.2.2)

Updates `vite-plugin-vuetify` from 2.0.3 to 2.0.4
- [Release notes](https://github.com/vuetifyjs/vuetify-loader/releases)
- [Commits](https://github.com/vuetifyjs/vuetify-loader/compare/vite-plugin-vuetify@2.0.3...vite-plugin-vuetify@2.0.4)

Updates `vue` from 3.4.27 to 3.4.38
- [Release notes](https://github.com/vuejs/core/releases)
- [Changelog](https://github.com/vuejs/core/blob/v3.4.38/CHANGELOG.md)
- [Commits](vuejs/core@v3.4.27...v3.4.38)

Updates `vue-router` from 4.3.2 to 4.4.3
- [Release notes](https://github.com/vuejs/router/releases)
- [Commits](vuejs/router@v4.3.2...v4.4.3)

Updates `vuetify` from 3.6.7 to 3.7.1
- [Release notes](https://github.com/vuetifyjs/vuetify/releases)
- [Commits](https://github.com/vuetifyjs/vuetify/commits/v3.7.1/packages/vuetify)

---
updated-dependencies:
- dependency-name: "@fontsource/roboto"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: production-dependencies
- dependency-name: axios
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: production-dependencies
- dependency-name: dayjs
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: production-dependencies
- dependency-name: pinia
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: production-dependencies
- dependency-name: vite-plugin-vuetify
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: production-dependencies
- dependency-name: vue
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: production-dependencies
- dependency-name: vue-router
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: production-dependencies
- dependency-name: vuetify
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: production-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps the production-dependencies group in /scraper with 9 updates:

| Package | From | To |
| --- | --- | --- |
| [zimscraperlib](https://github.com/openzim/python-scraperlib) | `3.4.0` | `4.0.0` |
| [pydantic](https://github.com/pydantic/pydantic) | `2.7.2` | `2.8.2` |
| [black](https://github.com/psf/black) | `24.4.2` | `24.8.0` |
| [ruff](https://github.com/astral-sh/ruff) | `0.4.10` | `0.6.3` |
| [pyright](https://github.com/RobertCraigie/pyright-python) | `1.1.371` | `1.1.378` |
| [pytest](https://github.com/pytest-dev/pytest) | `8.2.2` | `8.3.2` |
| [coverage](https://github.com/nedbat/coveragepy) | `7.5.3` | `7.6.1` |
| [pre-commit](https://github.com/pre-commit/pre-commit) | `3.7.1` | `3.8.0` |
| [debugpy](https://github.com/microsoft/debugpy) | `1.8.1` | `1.8.5` |


Updates `zimscraperlib` from 3.4.0 to 4.0.0
- [Release notes](https://github.com/openzim/python-scraperlib/releases)
- [Changelog](https://github.com/openzim/python-scraperlib/blob/main/CHANGELOG.md)
- [Commits](openzim/python-scraperlib@v3.4.0...v4.0.0)

Updates `pydantic` from 2.7.2 to 2.8.2
- [Release notes](https://github.com/pydantic/pydantic/releases)
- [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md)
- [Commits](pydantic/pydantic@v2.7.2...v2.8.2)

Updates `black` from 24.4.2 to 24.8.0
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](psf/black@24.4.2...24.8.0)

Updates `ruff` from 0.4.10 to 0.6.3
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@v0.4.10...0.6.3)

Updates `pyright` from 1.1.371 to 1.1.378
- [Release notes](https://github.com/RobertCraigie/pyright-python/releases)
- [Commits](RobertCraigie/pyright-python@v1.1.371...v1.1.378)

Updates `pytest` from 8.2.2 to 8.3.2
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@8.2.2...8.3.2)

Updates `coverage` from 7.5.3 to 7.6.1
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@7.5.3...7.6.1)

Updates `pre-commit` from 3.7.1 to 3.8.0
- [Release notes](https://github.com/pre-commit/pre-commit/releases)
- [Changelog](https://github.com/pre-commit/pre-commit/blob/main/CHANGELOG.md)
- [Commits](pre-commit/pre-commit@v3.7.1...v3.8.0)

Updates `debugpy` from 1.8.1 to 1.8.5
- [Release notes](https://github.com/microsoft/debugpy/releases)
- [Commits](microsoft/debugpy@v1.8.1...v1.8.5)

---
updated-dependencies:
- dependency-name: zimscraperlib
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: production-dependencies
- dependency-name: pydantic
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: production-dependencies
- dependency-name: black
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: production-dependencies
- dependency-name: ruff
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: production-dependencies
- dependency-name: pyright
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: production-dependencies
- dependency-name: pytest
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: production-dependencies
- dependency-name: coverage
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: production-dependencies
- dependency-name: pre-commit
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: production-dependencies
- dependency-name: debugpy
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: production-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps the development-dependencies group in /zimui with 17 updates:

| Package | From | To |
| --- | --- | --- |
| [@rushstack/eslint-patch](https://github.com/microsoft/rushstack/tree/HEAD/eslint/eslint-patch) | `1.10.3` | `1.10.4` |
| [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `20.12.12` | `22.5.2` |
| [@vitejs/plugin-legacy](https://github.com/vitejs/vite/tree/HEAD/packages/plugin-legacy) | `5.4.1` | `5.4.2` |
| [@vitejs/plugin-vue](https://github.com/vitejs/vite-plugin-vue/tree/HEAD/packages/plugin-vue) | `5.0.4` | `5.1.3` |
| [cypress](https://github.com/cypress-io/cypress) | `13.11.0` | `13.14.1` |
| [eslint](https://github.com/eslint/eslint) | `8.57.0` | `9.9.1` |
| [eslint-plugin-vue](https://github.com/vuejs/eslint-plugin-vue) | `9.26.0` | `9.28.0` |
| [jsdom](https://github.com/jsdom/jsdom) | `24.1.0` | `25.0.0` |
| [npm-run-all2](https://github.com/bcomnes/npm-run-all2) | `6.2.0` | `6.2.2` |
| [ogv](https://github.com/bvibber/ogv.js) | `1.8.9` | `1.9.0` |
| [prettier](https://github.com/prettier/prettier) | `3.2.5` | `3.3.3` |
| [terser](https://github.com/terser/terser) | `5.31.3` | `5.31.6` |
| [typescript](https://github.com/Microsoft/TypeScript) | `5.4.5` | `5.5.4` |
| [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) | `5.2.11` | `5.4.2` |
| [vite-plugin-static-copy](https://github.com/sapphi-red/vite-plugin-static-copy) | `1.0.5` | `1.0.6` |
| [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) | `1.6.0` | `2.0.5` |
| [vue-tsc](https://github.com/vuejs/language-tools/tree/HEAD/packages/tsc) | `2.0.19` | `2.1.4` |

Updates `@rushstack/eslint-patch` from 1.10.3 to 1.10.4
- [Changelog](https://github.com/microsoft/rushstack/blob/main/eslint/eslint-patch/CHANGELOG.md)
- [Commits](https://github.com/microsoft/rushstack/commits/@rushstack/eslint-patch_v1.10.4/eslint/eslint-patch)

Updates `@types/node` from 20.12.12 to 22.5.2
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Updates `@vitejs/plugin-legacy` from 5.4.1 to 5.4.2
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/plugin-legacy/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.2/packages/plugin-legacy)

Updates `@vitejs/plugin-vue` from 5.0.4 to 5.1.3
- [Release notes](https://github.com/vitejs/vite-plugin-vue/releases)
- [Changelog](https://github.com/vitejs/vite-plugin-vue/blob/main/packages/plugin-vue/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite-plugin-vue/commits/plugin-vue@5.1.3/packages/plugin-vue)

Updates `cypress` from 13.11.0 to 13.14.1
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/CHANGELOG.md)
- [Commits](cypress-io/cypress@v13.11.0...v13.14.1)

Updates `eslint` from 8.57.0 to 9.9.1
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.57.0...v9.9.1)

Updates `eslint-plugin-vue` from 9.26.0 to 9.28.0
- [Release notes](https://github.com/vuejs/eslint-plugin-vue/releases)
- [Commits](vuejs/eslint-plugin-vue@v9.26.0...v9.28.0)

Updates `jsdom` from 24.1.0 to 25.0.0
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/main/Changelog.md)
- [Commits](jsdom/jsdom@24.1.0...25.0.0)

Updates `npm-run-all2` from 6.2.0 to 6.2.2
- [Release notes](https://github.com/bcomnes/npm-run-all2/releases)
- [Changelog](https://github.com/bcomnes/npm-run-all2/blob/master/CHANGELOG.md)
- [Commits](bcomnes/npm-run-all2@v6.2.0...v6.2.2)

Updates `ogv` from 1.8.9 to 1.9.0
- [Release notes](https://github.com/bvibber/ogv.js/releases)
- [Changelog](https://github.com/bvibber/ogv.js/blob/main/CHANGES.md)
- [Commits](bvibber/ogv.js@1.8.9...1.9.0)

Updates `prettier` from 3.2.5 to 3.3.3
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.2.5...3.3.3)

Updates `terser` from 5.31.3 to 5.31.6
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/commits)

Updates `typescript` from 5.4.5 to 5.5.4
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml)
- [Commits](microsoft/TypeScript@v5.4.5...v5.5.4)

Updates `vite` from 5.2.11 to 5.4.2
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.2/packages/vite)

Updates `vite-plugin-static-copy` from 1.0.5 to 1.0.6
- [Release notes](https://github.com/sapphi-red/vite-plugin-static-copy/releases)
- [Changelog](https://github.com/sapphi-red/vite-plugin-static-copy/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sapphi-red/vite-plugin-static-copy/compare/vite-plugin-static-copy@1.0.5...vite-plugin-static-copy@1.0.6)

Updates `vitest` from 1.6.0 to 2.0.5
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v2.0.5/packages/vitest)

Updates `vue-tsc` from 2.0.19 to 2.1.4
- [Release notes](https://github.com/vuejs/language-tools/releases)
- [Changelog](https://github.com/vuejs/language-tools/blob/master/CHANGELOG.md)
- [Commits](https://github.com/vuejs/language-tools/commits/v2.1.4/packages/tsc)

---
updated-dependencies:
- dependency-name: "@rushstack/eslint-patch"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: development-dependencies
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: development-dependencies
- dependency-name: "@vitejs/plugin-legacy"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: development-dependencies
- dependency-name: "@vitejs/plugin-vue"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development-dependencies
- dependency-name: cypress
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development-dependencies
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: development-dependencies
- dependency-name: eslint-plugin-vue
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development-dependencies
- dependency-name: jsdom
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: development-dependencies
- dependency-name: npm-run-all2
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: development-dependencies
- dependency-name: ogv
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development-dependencies
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development-dependencies
- dependency-name: terser
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: development-dependencies
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development-dependencies
- dependency-name: vite
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development-dependencies
- dependency-name: vite-plugin-static-copy
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: development-dependencies
- dependency-name: vitest
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: development-dependencies
- dependency-name: vue-tsc
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
@benoit74 benoit74 added this to the 3.1.0 milestone Sep 3, 2024
@benoit74 benoit74 self-assigned this Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 1.52%. Comparing base (b189d90) to head (7ffaea6).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/youtube2zim/scraper.py 0.00% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #306      +/-   ##
========================================
+ Coverage   1.51%   1.52%   +0.01%     
========================================
  Files         11      11              
  Lines       1125    1112      -13     
  Branches     166     166              
========================================
  Hits          17      17              
+ Misses      1108    1095      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74
Copy link
Collaborator Author

benoit74 commented Sep 3, 2024

Remark: current version of https://github.com/vuejs/create-vue is still using eslint 8.57.0, so it is probably a good indicator that the ecosystem is really not yet ready, it is not just me and my limited JS knowledge. See vuejs/create-vue#488

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit 8cccef5 into main Sep 5, 2024
10 checks passed
@benoit74 benoit74 deleted the upgrade_deps branch September 5, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants