Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration tests to check content in ZIM #268

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

dan-niles
Copy link
Collaborator

@dan-niles dan-niles commented Jul 15, 2024

Close #253

  • Update test_zim_scraper to check more metadata of the ZIM
  • Add test_zim_channel_json to check contents of channel.json
  • Add test_zim_videos to check existence of video json files, video files, video thumbnails and subtitles.
  • Add test_zim_playlists to check existence of playlists json files

@dan-niles dan-niles self-assigned this Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.54%. Comparing base (1ba45c3) to head (0fcb9b3).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #268   +/-   ##
=====================================
  Coverage   1.54%   1.54%           
=====================================
  Files         11      11           
  Lines       1102    1102           
  Branches     162     162           
=====================================
  Hits          17      17           
  Misses      1085    1085           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dan-niles dan-niles marked this pull request as ready for review July 15, 2024 16:48
@dan-niles dan-niles requested a review from benoit74 July 15, 2024 16:48
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you !

@benoit74 benoit74 merged commit 5d53b9e into main Jul 17, 2024
10 checks passed
@benoit74 benoit74 deleted the update-integration-tests branch July 17, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write integration tests for the scraper
2 participants