Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update publisher metadata from 'Kiwix' to 'openZIM' #296

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Update publisher metadata from 'Kiwix' to 'openZIM' #296

merged 2 commits into from
Mar 12, 2024

Conversation

dan-niles
Copy link
Contributor

Resolves #291
Updated publisher metadata to 'openZIM' in entrypoint.py and scraper.py.

benoit74
benoit74 requested changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix comment and add an entry to CHANGELOG.md, in the "Unreleased" section ("Fixed" or "Changed" subsection, not sure which one is more appropriate, I let you choose, it is not that important anyway)

src/sotoki/entrypoint.py Outdated Show resolved Hide resolved
@dan-niles dan-niles requested a review from benoit74 March 8, 2024 05:36
benoit74
benoit74 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit d756611 into openzim:main Mar 12, 2024
4 checks passed
@dan-niles dan-niles deleted the update-publisher branch March 12, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoit74 benoit74 benoit74 approved these changes

Assignees

@dan-niles dan-niles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harmonize default publisher to openZIM
2 participants
@dan-niles @benoit74