Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance error when locale fails to setup #180

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

benoit74
Copy link
Collaborator

Fix #157

  • Enhance locale setup error message for easier understanding
  • Add more information about locale requirement in README

@benoit74 benoit74 self-assigned this Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (efc2942) to head (5d3ee5a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #180   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          33       33           
  Lines        1546     1549    +3     
  Branches      279      279           
=======================================
+ Hits         1545     1548    +3     
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review July 10, 2024 15:24
@benoit74 benoit74 requested a review from rgaudin July 10, 2024 15:24
@benoit74 benoit74 merged commit 0feff56 into main Jul 30, 2024
10 checks passed
@benoit74 benoit74 deleted the enhance_locale_error branch July 30, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unchanged project has two test failures
2 participants