Fix

.github/workflows/QA.yaml

@@ -37,6 +37,7 @@ jobs:
             javascript/src/fuzzyRules.js
             javascript/test/fuzzyRules.js
           name: rules
+          retention-days: 1
 
   check-python-qa:
     runs-on: ubuntu-24.04
@@ -48,21 +49,8 @@ jobs:
       - name: Restore rules artifact
         uses: actions/download-artifact@v4
         with:
-          path: |
-            src/zimscraperlib/rewriting/rules.py
-            tests/rewriting/test_fuzzy_rules.py
-            javascript/src/fuzzyRules.js
-            javascript/test/fuzzyRules.js
           name: rules
 
-      - name: Temp check
-        run: |
-          ls -lah .
-          ls -lah src/zimscraperlib/rewriting/rules.py
-          ls -lah tests/rewriting/test_fuzzy_rules.py
-          ls -lah javascript/src/fuzzyRules.js
-          ls -lah javascript/test/fuzzyRules.js
-
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
@@ -93,11 +81,6 @@ jobs:
       - name: Restore rules artifact
         uses: actions/download-artifact@v4
         with:
-          path: |
-            src/zimscraperlib/rewriting/rules.py
-            tests/rewriting/test_fuzzy_rules.py
-            javascript/src/fuzzyRules.js
-            javascript/test/fuzzyRules.js
           name: rules
 
       - name: Temp check

.github/workflows/Tests.yaml

@@ -7,12 +7,50 @@ on:
       - main
 
 jobs:
+  generate-rules:
+    runs-on: ubuntu-24.04
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version-file: pyproject.toml
+          architecture: x64
+
+      - name: Install dependencies (and project)
+        run: |
+          pip install -U pip
+          pip install -e .[scripts]
+
+      - name: Generate rules
+        run: |
+          python rules/generate_rules.py
+
+      - name: Save rules artifact
+        uses: actions/upload-artifact@v4
+        with:
+          path: |
+            src/zimscraperlib/rewriting/rules.py
+            tests/rewriting/test_fuzzy_rules.py
+            javascript/src/fuzzyRules.js
+            javascript/test/fuzzyRules.js
+          name: rules
+          retention-days: 1
+
   run-python-tests:
     runs-on: ubuntu-24.04
+    needs: generate-rules
 
     steps:
       - uses: actions/checkout@v4
 
+      - name: Restore rules artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: rules
+
       - name: install ffmpeg and gifsicle
         run: sudo apt update && sudo apt install ffmpeg gifsicle
 
@@ -38,9 +76,15 @@ jobs:
 
   build_python:
     runs-on: ubuntu-24.04
+    needs: generate-rules
     steps:
       - uses: actions/checkout@v4
 
+      - name: Restore rules artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: rules
+
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
@@ -54,8 +98,15 @@ jobs:
 
   build_javascript:
     runs-on: ubuntu-24.04
+    needs: generate-rules
     steps:
       - uses: actions/checkout@v4
+
+      - name: Restore rules artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: rules
+
       # Setup .npmrc file to publish to npm
       - uses: actions/setup-node@v4
         with:

src/zimscraperlib/rewriting/url_rewriting.py

@@ -81,6 +81,9 @@ def __hash__(self) -> int:
     def __str__(self) -> str:
         return f"HttpUrl({self.value})"
 
+    def __repr__(self) -> str:
+        return f"{self.__str__} - {super().__repr__()}"  # pragma: no cover
+
     @property
     def value(self) -> str:
         return self._value
@@ -120,6 +123,9 @@ def __hash__(self) -> int:
     def __str__(self) -> str:
         return f"ZimPath({self.value})"
 
+    def __repr__(self) -> str:
+        return f"{self.__str__} - {super().__repr__()}"  # pragma: no cover
+
     @property
     def value(self) -> str:
         return self._value
@@ -357,10 +363,15 @@ def normalize(cls, url: HttpUrl) -> ZimPath:
         passed to python-libzim for UTF-8 encoding.
         """
 
+        if not isinstance(url, HttpUrl):
+            raise ValueError("Bad argument type passed, HttpUrl expected")
+
         url_parts = urlsplit(url.value)
 
         if not url_parts.hostname:
-            raise Exception("Hostname is missing")
+            # cannot happen because of the HttpUrl checks, but important to please the
+            # type checker
+            raise Exception("Hostname is missing")  # pragma: no cover
 
         # decode the hostname if it is punny-encoded
         hostname = (