Use language with variants with biggest count of simulations. other should be removed. #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pavel-karatsiuba please rebase and fix conflict |
pavel-karatsiuba
force-pushed
the
without-language-variants
branch
from
b90520c
to
a865fde
Compare
|
@pavel-karatsiuba I'm very sorry, because of my being slow, I have to ask you a last time here to rebase and fix conflict. |
kelson42
changed the title
pavel-karatsiuba
force-pushed
the
without-language-variants
branch
from
a865fde
to
e55dd88
Compare
…hould be removed.
kelson42
force-pushed
the
without-language-variants
branch
from
e55dd88
to
2b9c590
Compare
kelson42
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed logic to use --withoutLanguageVariants parameter.
When using --withoutLanguageVariants do not just remove languages with variants but use language with variants with the biggest count of simulations.
For example, if
kulanguage has 41 simulations andku_TRhas 63 then forkulanguage use simulations fromku_TR. So in output, you will not seeku_TRbut you will seekuwith 63 simulations.Fix: #207