-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Metadata LongDescription #1755
Conversation
e7d63b2
to
8946de3
Compare
Codecov ReportBase: 69.11% // Head: 69.56% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1755 +/- ##
==========================================
+ Coverage 69.11% 69.56% +0.44%
==========================================
Files 23 23
Lines 2477 2579 +102
Branches 588 588
==========================================
+ Hits 1712 1794 +82
- Misses 651 673 +22
+ Partials 114 112 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- value should not be sliced
- If not set it should not be empty string, it should simply be undefined
- Values shoukd sanitized and if too long an error shoukd be generated
faac407
to
9bdc816
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Argument check and sanitation should be in
sanitize-argument.ts
- Please add same form
description
(should not be longer than 80 characters) - please add an automated test to test properly all the ZIM Metadata using
zimdump
. For example `zimdump show --url "M/LongDescription".
…Don't set empty LongDescription.
9fb07ef
to
7bcdcaa
Compare
Add new parameter customZimDescription which set LongDescription to zim file
Fix: #1663