Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Metadata LongDescription #1755

Merged
merged 7 commits into from
Jan 31, 2023
Merged

Conversation

pavel-karatsiuba
Copy link
Contributor

Add new parameter customZimDescription which set LongDescription to zim file

Fix: #1663

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 69.11% // Head: 69.56% // Increases project coverage by +0.44% 🎉

Coverage data is based on head (9fb07ef) compared to base (e66c8e8).
Patch coverage: 90.90% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1755      +/-   ##
==========================================
+ Coverage   69.11%   69.56%   +0.44%     
==========================================
  Files          23       23              
  Lines        2477     2579     +102     
  Branches      588      588              
==========================================
+ Hits         1712     1794      +82     
- Misses        651      673      +22     
+ Partials      114      112       -2     
Impacted Files Coverage Δ
src/Dump.ts 81.18% <ø> (ø)
test/util.ts 28.57% <87.50%> (+11.49%) ⬆️
src/mwoffliner.lib.ts 71.47% <100.00%> (-0.79%) ⬇️
src/util/mw-api.ts 83.06% <0.00%> (-5.31%) ⬇️
src/util/saveArticles.ts 81.10% <0.00%> (-1.17%) ⬇️
src/util/const.ts 100.00% <0.00%> (ø)
src/util/categories.ts 0.00% <0.00%> (ø)
src/util/rewriteUrls.ts 84.35% <0.00%> (ø)
src/stores.ts
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pavel-karatsiuba pavel-karatsiuba marked this pull request as ready for review January 27, 2023 13:50
Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • value should not be sliced
  • If not set it should not be empty string, it should simply be undefined
  • Values shoukd sanitized and if too long an error shoukd be generated

Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Argument check and sanitation should be in sanitize-argument.ts
  • Please add same form description (should not be longer than 80 characters)
  • please add an automated test to test properly all the ZIM Metadata using zimdump. For example `zimdump show --url "M/LongDescription".

@kelson42 kelson42 merged commit 7902135 into main Jan 31, 2023
@kelson42 kelson42 deleted the add-metadata-longdescription branch January 31, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Metadata LongDescription
2 participants