Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint instead tslint #1738

Merged
merged 4 commits into from
Jan 20, 2023
Merged

Eslint instead tslint #1738

merged 4 commits into from
Jan 20, 2023

Conversation

pavel-karatsiuba
Copy link
Contributor

@pavel-karatsiuba pavel-karatsiuba commented Jan 18, 2023

Fixes #1699

@uriesk
Copy link
Collaborator

uriesk commented Jan 18, 2023

good luck with that one :)

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 69.03% // Head: 68.95% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (47ab9a2) compared to base (8a521dd).
Patch coverage: 66.44% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1738      +/-   ##
==========================================
- Coverage   69.03%   68.95%   -0.09%     
==========================================
  Files          23       23              
  Lines        2503     2461      -42     
  Branches      614      580      -34     
==========================================
- Hits         1728     1697      -31     
+ Misses        665      654      -11     
  Partials      110      110              
Impacted Files Coverage Δ
src/S3.ts 0.00% <0.00%> (ø)
src/config.ts 100.00% <ø> (ø)
src/util/categories.ts 0.00% <0.00%> (ø)
test/util.ts 17.07% <15.15%> (ø)
src/util/articleListMainPage.ts 33.33% <25.00%> (ø)
src/Redis.ts 60.00% <33.33%> (ø)
src/Downloader.ts 58.17% <52.19%> (+0.68%) ⬆️
src/DOMUtils.ts 56.25% <55.55%> (ø)
src/util/articleRenderers.ts 61.29% <60.43%> (-0.17%) ⬇️
src/Logger.ts 78.94% <66.66%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelson42 kelson42 merged commit 0ce4c24 into main Jan 20, 2023
@kelson42 kelson42 deleted the eslint-instead-tslint branch January 20, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ESLint instead of TSLint
4 participants