Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle properly Fandom image src links #1712

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Conversation

kelson42
Copy link
Collaborator

@kelson42 kelson42 commented Jan 5, 2023

Fixes #1710
Superseeds #1711

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 68.97% // Head: 69.01% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (0394f2e) compared to base (df3545a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1712      +/-   ##
==========================================
+ Coverage   68.97%   69.01%   +0.03%     
==========================================
  Files          26       26              
  Lines        2392     2395       +3     
  Branches      466      467       +1     
==========================================
+ Hits         1650     1653       +3     
  Misses        579      579              
  Partials      163      163              
Impacted Files Coverage Δ
src/util/const.ts 100.00% <100.00%> (ø)
src/util/misc.ts 79.39% <100.00%> (+0.20%) ⬆️
src/util/saveArticles.ts 83.13% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kelson42 kelson42 changed the title Handle properly Fandom image links Handle properly Fandom image src links Jan 5, 2023
@uriesk
Copy link
Collaborator

uriesk commented Jan 5, 2023

Consider that the Downloader is deciding on whether he converts or not based on the content-type, which is not available at the article scrapping stage. So a new regexp for [url].[ext]/revision/* can't be avoided.

Copy link
Contributor

@pavel-karatsiuba pavel-karatsiuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelson42 kelson42 merged commit 8fd75b7 into main Jan 5, 2023
@kelson42 kelson42 deleted the handle-fandom-image-links branch January 5, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--webp option assumes that image links end-up with an extension
3 participants