Testing grab inline js with config variables from HTML

openzim · Feb 18, 2023 · 061b04e · 061b04e
1 parent d6fa4a4
commit 061b04e
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/src/util/saveArticles.ts b/src/util/saveArticles.ts
@@ -369,7 +369,7 @@ export async function saveArticles(zimCreator: ZimCreator, downloader: Downloade
   }
 }
 
-async function getModuleDependencies(articleId: string, mw: MediaWiki, downloader: Downloader) {
+export async function getModuleDependencies(articleId: string, mw: MediaWiki, downloader: Downloader) {
   /* These vars will store the list of js and css dependencies for
     the article we are downloading. */
   let jsConfigVars = ''

diff --git a/test/unit/saveArticles.test.ts b/test/unit/saveArticles.test.ts
@@ -2,7 +2,7 @@ import { startRedis, stopRedis, redisStore } from './bootstrap.js'
 import domino from 'domino'
 
 import { setupScrapeClasses, convertWikicodeToHtml, testHtmlRewritingE2e } from '../util.js'
-import { saveArticles, treatMedias, applyOtherTreatments, treatSubtitle, treatVideo } from '../../src/util/saveArticles.js'
+import { saveArticles, getModuleDependencies, treatMedias, applyOtherTreatments, treatSubtitle, treatVideo } from '../../src/util/saveArticles.js'
 import { ZimArticle } from '@openzim/libzim'
 import { Dump } from '../../src/Dump'
 import { mwRetToArticleDetail, renderDesktopArticle, DELETED_ARTICLE_ERROR } from '../../src/util/index.js'
@@ -349,4 +349,29 @@ describe('saveArticles', () => {
     // Throwing error if article is deleted
     expect(() => renderDesktopArticle(articleJsonObject, 'deletedArticle', { title: 'deletedArticle' })).toThrow(new Error(DELETED_ARTICLE_ERROR))
   })
+
+  test('Load inline js from HTML', async () => {
+    const { downloader, mw } = await setupScrapeClasses() // en wikipedia
+
+    const _moduleDependencies = await getModuleDependencies('Potato', mw, downloader)
+    // next variables declared to avoid "variable is not defined" errors
+    let RLCONF: any
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    let RLSTATE: any
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    let RLPAGEMODULES: any
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    const document: any = { documentElement: { className: '' }, cookie: '' }
+
+    // eslint-disable-next-line no-eval
+    eval(_moduleDependencies.jsConfigVars)
+    expect(RLCONF).toMatchObject({
+      wgPageName: 'Potato',
+      wgTitle: 'Potato',
+      wgPageContentLanguage: 'en',
+      wgPageContentModel: 'wikitext',
+      wgRelevantPageName: 'Potato',
+      wgRelevantArticleId: 23501,
+    })
+  })
 })