Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply proper CSS for proper page display - step 1 #29

Merged
merged 1 commit into from
Oct 10, 2024

Apply proper CSS for proper page display - step 1

4749161
Select commit
Loading
Failed to load commit list.
Merged

Apply proper CSS for proper page display - step 1 #29

Apply proper CSS for proper page display - step 1
4749161
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 10, 2024 in 0s

51.48% (+4.25%) compared to 733c35a

View this Pull Request on Codecov

51.48% (+4.25%) compared to 733c35a

Details

Codecov Report

Attention: Patch coverage is 68.51852% with 34 lines in your changes missing coverage. Please review.

Project coverage is 51.48%. Comparing base (733c35a) to head (4749161).

Files with missing lines Patch % Lines
scraper/src/libretexts2zim/processor.py 8.69% 21 Missing ⚠️
scraper/src/libretexts2zim/client.py 35.71% 9 Missing ⚠️
scraper/src/libretexts2zim/css.py 93.22% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   47.22%   51.48%   +4.25%     
==========================================
  Files           7        9       +2     
  Lines         432      540     +108     
  Branches       45       61      +16     
==========================================
+ Hits          204      278      +74     
- Misses        226      258      +32     
- Partials        2        4       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov