Optimization of the first call of zim::Archive::iterEfficient() #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
==========================================
+ Coverage 84.57% 84.67% +0.09%
==========================================
Files 98 98
Lines 4297 4325 +28
Branches 1864 1869 +5
==========================================
+ Hits 3634 3662 +28
Misses 662 662
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mgautierfr
requested changes
Aug 22, 2022
|
LGTM. Please rebase-fixup on master |
The new class Grouping<ObjectId, GroupId> implements the current straightforward approach for sorting the dirents in cluster order, but opens a way for switching to a better solution. A user-observable effect of this change is the lower memory usage after `FileImpl::prepareArticleListByCluster()` has completed (but an increased high-watermark memory usage of that function).
Got rid of O(NlogN) sorting in FileImpl::prepareArticleListByCluster(). Now its time-complexitiy is O(N). Also, its high-watermark memory usage was lowered roughly to the level before Grouping was introduced.
veloman-yunkan
force-pushed
the
optimization_of_iterEfficient
branch
from
bb7c998
to
5e2d46b
Compare
Done |
mgautierfr
approved these changes
Aug 22, 2022
mgautierfr
added a commit
that referenced
this pull request
Nov 30, 2022
* Optimization ofthe first call to `zim::Archive::iterEfficient` (@veloman-yunkan #724) * Add some documentation to `zim::writer::IndexData` (@mgautierfr #727) * Correctly catch and rethrow exception thrown in worker threads at creation (@mgautierfr #496 #748) * Optimization of `Entry::getItem()` (@veloman-yunkan #732) * Fix declaration of `zim::setICUDataDirectory()` (@MohitMaliFtechiz #733) * Add `zim::Archive::getMediatCount()` (@mgautierfr #730) * Make compilaton of examples optional (@mgautierfr #738) * Add a CI for wasm (@mgautierfr #746) * Make constructor of SuggestionItem public (@veloman-yunkan #740)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileImpl::m_articleListByClusterhas been halved