Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade scraper (Python conventions, Python version and dependencies) #96

Merged
merged 8 commits into from
Mar 2, 2024

Rearrange code to get rid of the Global class

7370031
Select commit
Loading
Failed to load commit list.
Merged

Upgrade scraper (Python conventions, Python version and dependencies) #96

Rearrange code to get rid of the Global class
7370031
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 2, 2024 in 0s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

Attention: Patch coverage is 0% with 882 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@a14ce78). Click here to learn what that means.

Files Patch % Lines
src/ifixit2zim/processor.py 0.00% 232 Missing ⚠️
src/ifixit2zim/scraper.py 0.00% 222 Missing ⚠️
src/ifixit2zim/utils.py 0.00% 94 Missing ⚠️
src/ifixit2zim/constants.py 0.00% 68 Missing ⚠️
src/ifixit2zim/scraper_guide.py 0.00% 40 Missing ⚠️
src/ifixit2zim/scraper_generic.py 0.00% 32 Missing ⚠️
src/ifixit2zim/imager.py 0.00% 30 Missing ⚠️
src/ifixit2zim/scraper_category.py 0.00% 29 Missing ⚠️
src/ifixit2zim/scraper_info.py 0.00% 29 Missing ⚠️
src/ifixit2zim/scraper_homepage.py 0.00% 24 Missing ⚠️
... and 7 more
Additional details and impacted files
@@          Coverage Diff           @@
##             main     #96   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?      17           
  Lines           ?    1665           
  Branches        ?     293           
======================================
  Hits            ?       0           
  Misses          ?    1665           
  Partials        ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.