Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: Fix in-tree dbufstats test case #9196

Merged
merged 1 commit into from
Aug 23, 2019
Merged

ZTS: Fix in-tree dbufstats test case #9196

merged 1 commit into from
Aug 23, 2019

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Issue #9118

Description

Commit a887d65 updated the dbufstats such that escalated privileges
are required. Since all tests under cli_user are run with normal
privileges move this test case to a location where it will be run
required privileges.

How Has This Been Tested?

$ ./scripts/zfs-tests.sh -T arc
Test: /home/behlendo/src/git/zfs/tests/zfs-tests/tests/functional/arc/setup (run as root) [00:01] [PASS]
Test: /home/behlendo/src/git/zfs/tests/zfs-tests/tests/functional/arc/dbufstats_001_pos (run as root) [00:01] [PASS]
Test: /home/behlendo/src/git/zfs/tests/zfs-tests/tests/functional/arc/dbufstats_002_pos (run as root) [00:00] [PASS]
Test: /home/behlendo/src/git/zfs/tests/zfs-tests/tests/functional/arc/dbufstats_003_pos (run as root) [00:01] [PASS]
Test: /home/behlendo/src/git/zfs/tests/zfs-tests/tests/functional/arc/cleanup (run as root) [00:00] [PASS]

Results Summary
PASS	   5

Running Time:	00:00:06
Percent passed:	100.0%
Log directory:	/var/tmp/test_results/20190821T130645

Tests with results other than PASS that are expected:

Tests with result of PASS that are unexpected:

Tests with results other than PASS that are unexpected:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf
ZTS: Fix in-tree dbufstats test case
f5ba8a9 
Commit a887d65 updated the dbufstats such that escalated privileges
are required.  Since all tests under cli_user are run with normal
priveleges move this test case to a location where it will be run
required privileges.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Aug 21, 2019
@behlendorf behlendorf mentioned this pull request Aug 21, 2019
Closed
c0d3z3r0
c0d3z3r0 approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@c0d3z3r0 c0d3z3r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Aug 22, 2019 •
edited
Loading

Codecov Report

Merging #9196 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9196      +/-   ##
==========================================
- Coverage   79.22%   79.14%   -0.09%     
==========================================
  Files         400      400              
  Lines      122001   122001              
==========================================
- Hits        96656    96553     -103     
- Misses      25345    25448     +103
Flag Coverage Δ
#kernel 79.72% <ø> (-0.02%) ⬇️
#user 66.94% <ø> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9ebdfd...f5ba8a9. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 22, 2019
@behlendorf behlendorf merged commit 4302698 into openzfs:master Aug 23, 2019
ghost pushed a commit to zfsonfreebsd/ZoF that referenced this pull request Aug 26, 2019
@behlendorf
ZTS: Fix in-tree dbufstats test case
51da792 
Commit a887d65 updated the dbufstats such that escalated privileges
are required.  Since all tests under cli_user are run with normal
privileges move this test case to a location where it will be run
required privileges.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9118 
Closes openzfs#9196
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 24, 2019
@behlendorf @tonyhutter
ZTS: Fix in-tree dbufstats test case
d10bfe8 
Commit a887d65 updated the dbufstats such that escalated privileges
are required.  Since all tests under cli_user are run with normal
privileges move this test case to a location where it will be run
required privileges.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9118
Closes openzfs#9196
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 27, 2019
@behlendorf @tonyhutter
ZTS: Fix in-tree dbufstats test case
30ab789 
Commit a887d65 updated the dbufstats such that escalated privileges
are required.  Since all tests under cli_user are run with normal
privileges move this test case to a location where it will be run
required privileges.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9118
Closes openzfs#9196
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
@behlendorf @tonyhutter
ZTS: Fix in-tree dbufstats test case
9ad6f69 
Commit a887d65 updated the dbufstats such that escalated privileges
are required.  Since all tests under cli_user are run with normal
privileges move this test case to a location where it will be run
required privileges.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #9118
Closes #9196
@behlendorf behlendorf deleted the issue-9118 branch April 19, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwk404 jwk404 jwk404 approved these changes

@c0d3z3r0 c0d3z3r0 c0d3z3r0 approved these changes

Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@behlendorf @jwk404 @c0d3z3r0