Fallback to strerror() when strerror_l() isn't available #16640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
added
Type: Building
It works correctly using glibc v13.3.0, musl v1.2.5, and uclibc v1.0.50. Tested-by: José Luis Salvador Rufo salvador.joseluis@gmail.com |
mcmilk
approved these changes
Oct 11, 2024
Some C libraries, such as uClibc, do not provide strerror_l() in which case we fallback to strerror(). Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
behlendorf
force-pushed
the
issue-16636
branch
from
a99ef9e to
1cc9e20
Compare
behlendorf
added
Status: Accepted
behlendorf
added a commit
to behlendorf/zfs
that referenced
this pull request
Oct 14, 2024
Some C libraries, such as uClibc, do not provide strerror_l() in which case we fallback to strerror(). Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#16636 Closes openzfs#16640
ptr1337
pushed a commit
to CachyOS/zfs
that referenced
this pull request
Nov 14, 2024
Some C libraries, such as uClibc, do not provide strerror_l() in which case we fallback to strerror(). Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#16636 Closes openzfs#16640
rkojedzinszky
added a commit
to rkojedzinszky/zfs
that referenced
this pull request
Jan 3, 2025
rkojedzinszky
added a commit
to rkojedzinszky/zfs
that referenced
this pull request
Jan 3, 2025
rkojedzinszky
added a commit
to rkojedzinszky/zfs
that referenced
this pull request
Jan 3, 2025
Fixes openzfs#15793 Fixes openzfs#16640 Signed-off-by: Richard Kojedzinszky <richard@kojedz.in>
13 tasks
rkojedzinszky
added a commit
to rkojedzinszky/zfs
that referenced
this pull request
Jan 3, 2025
Fixes openzfs#15793 Fixes openzfs#16640 Signed-off-by: Richard Kojedzinszky <richard@kojedz.in>
behlendorf
pushed a commit
that referenced
this pull request
Jan 4, 2025
#15793 wanted to make zfs_strerror threadsafe, unfortunately, it turned out that strerror_l() usage was wrong, and also, some libc implementations dont have strerror_l(). zfs_strerror() now simply calls original strerror() and copies the result to a thread-local buffer, then returns that. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Richard Kojedzinszky <richard@kojedz.in> Closes #15793 Closes #16640 Closes #16923
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Jan 4, 2025
openzfs#15793 wanted to make zfs_strerror threadsafe, unfortunately, it turned out that strerror_l() usage was wrong, and also, some libc implementations dont have strerror_l(). zfs_strerror() now simply calls original strerror() and copies the result to a thread-local buffer, then returns that. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Richard Kojedzinszky <richard@kojedz.in> Closes openzfs#15793 Closes openzfs#16640 Closes openzfs#16923
rkojedzinszky
added a commit
to dravanet/openzfs-zfs
that referenced
this pull request
Jan 5, 2025
openzfs#15793 wanted to make zfs_strerror threadsafe, unfortunately, it turned out that strerror_l() usage was wrong, and also, some libc implementations dont have strerror_l(). zfs_strerror() now simply calls original strerror() and copies the result to a thread-local buffer, then returns that. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Richard Kojedzinszky <richard@kojedz.in> Closes openzfs#15793 Closes openzfs#16640 Closes openzfs#16923
rkojedzinszky
added a commit
to dravanet/openzfs-zfs
that referenced
this pull request
Jan 6, 2025
turned out that strerror_l() usage was wrong, and also, some libc implementations dont have strerror_l(). zfs_strerror() now simply calls original strerror() and copies the result to a thread-local buffer, then returns that. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Richard Kojedzinszky <richard@kojedz.in> Closes openzfs#15793 Closes openzfs#16640 Closes openzfs#16923 Upstream commit dc0324b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#16636
Description
Some C libraries, such as uClibc, do not provide strerror_l() in which case we fallback to strerror().
How Has This Been Tested?
@jlsalvador would you mind testing this in your environment.
Types of changes