Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zdb: fix printf format in dump_zap() #16635

Merged
merged 1 commit into from
Oct 11, 2024
Merged

zdb: fix printf format in dump_zap() #16635

merged 1 commit into from
Oct 11, 2024
+1 −1

Conversation

mmatuska
Copy link
Contributor

Motivation and Context

When compiling zdb.c on 32-bit platforms, a format conversion error is reported for a printf() in dump_zap()

Description

Change %l to macro %" PRIu64 " to match the platform size of a 64-bit unsigned integer

How Has This Been Tested?

Compilation on FreeBSD and Ubuntu 24.10

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mmatuska mmatuska changed the title zdb: fix printf modifier in dump_zap() zdb: fix printf format in dump_zap() Oct 11, 2024
@mmatuska
zdb: fix printf format in dump_zap()
084dcd8 
Signed-off-by: Martin Matuska <mm@FreeBSD.org>
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Oct 11, 2024
@behlendorf behlendorf merged commit 7e4be92 into openzfs:master Oct 11, 2024
16 of 20 checks passed
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Oct 11, 2024
@mmatuska @behlendorf
zdb: fix printf format in dump_zap()
5816296 
When compiling zdb.c on 32-bit platforms, a format conversion error 
is reported for a printf() in dump_zap().  Change %l to macro 
%" PRIu64 " to match the platform size of a 64-bit unsigned integer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Martin Matuska <mm@FreeBSD.org>
Closes openzfs#16635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmatuska @behlendorf