Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only serialize native-deb* targets #16622

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

usaleem-ix
Copy link
Contributor

Motivation and Context

cc9e36a causes all the userspace components to build sequentially, when Debian packages are not being built.

Description

.NOTPARALLEL target is being enforced on all the userspace components. Remove .NOTPARALLEL target and only serialize native-deb* targets.

How Has This Been Tested?

Manual invocation of make -j utilizes all the resources, make -j native-deb, make -j native-deb-kmod native-deb-utils do not break.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

.NOTPARALLEL target is being forced on userspace as well. This commit
removes .NOTPARALEL target and only serializes the execution of
native-deb* targets.

Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
@snajpa
Copy link
Contributor

snajpa commented Oct 8, 2024

Works as expected, thank you!

Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. The strange thing is according to the .NOTPARALLEL documentation this should have worked as you intended.

If the .NOTPARALLEL special target has prerequisites, then each of those prerequisites will be considered a target and all prerequisites of these targets will be run serially. Note that only when building this target will the prerequisites be run serially: if some other target lists the same prerequisites and is not in .NOTPARALLEL then these prerequisites may be run in parallel.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Oct 8, 2024
@behlendorf behlendorf merged commit 65a94ff into openzfs:master Oct 8, 2024
20 checks passed
@usaleem-ix usaleem-ix deleted the fix-serial branch October 8, 2024 16:48
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Oct 9, 2024
.NOTPARALLEL target is being forced on userspace as well. This commit
removes .NOTPARALEL target and only serializes the execution of
native-deb* targets.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#16622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants