Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: Fix summary page creation again - second try #16611

Merged
merged 1 commit into from
Oct 6, 2024
Merged

ZTS: Fix summary page creation again - second try #16611

merged 1 commit into from
Oct 6, 2024

Conversation

mcmilk
Copy link
Contributor

@mcmilk mcmilk commented Oct 6, 2024 •
edited
Loading

Motivation and Context

In PR #16599 I used return like in C - which is wrong :/
The return will return / exit the whole script with an error... so no summary will be genereted et all.

This fix generates the summary as needed again.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mcmilk
ZTS: Fix summary page creation again - second try
5b06142 
In PR openzfs#16599 I used 'return' like in C - which is wrong :/
This fix generates the summary as needed.

Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Oct 6, 2024
@behlendorf behlendorf merged commit 995a3a6 into openzfs:master Oct 6, 2024
13 of 14 checks passed
@mcmilk mcmilk deleted the fix-summary2 branch October 8, 2024 05:11
ixhamza pushed a commit to truenas/zfs that referenced this pull request Oct 8, 2024
@mcmilk @ixhamza
ZTS: Fix summary page creation again - second try
29fcee5 
In PR openzfs#16599 I used 'return' like in C - which is wrong :/
This fix generates the summary as needed.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#16611
ixhamza pushed a commit to truenas/zfs that referenced this pull request Oct 9, 2024
@mcmilk @ixhamza
ZTS: Fix summary page creation again - second try
8be3a50 
In PR openzfs#16599 I used 'return' like in C - which is wrong :/
This fix generates the summary as needed.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#16611
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Oct 9, 2024
@mcmilk @behlendorf
ZTS: Fix summary page creation again - second try
f019b44 
In PR openzfs#16599 I used 'return' like in C - which is wrong :/
This fix generates the summary as needed.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#16611
ixhamza pushed a commit to truenas/zfs that referenced this pull request Oct 9, 2024
@mcmilk @ixhamza
ZTS: Fix summary page creation again - second try
017b9cf 
In PR openzfs#16599 I used 'return' like in C - which is wrong :/
This fix generates the summary as needed.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#16611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcmilk @behlendorf