Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

man: update recordsize max size info #16581

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

gmelikov
Copy link
Member

Reflect f2330bd change in our man pages and add some context.

Wording is primarily copy-pasted from code comments.

How Has This Been Tested?

man ./man/man7/zfsprops.7 and looked with my eyes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Reflect openzfs@f2330bd
change in our man pages and add some context.

Wording is primarily copy-pasted from code comments.

Signed-off-by: George Melikov <mail@gmelikov.ru>
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Sep 28, 2024
@behlendorf behlendorf merged commit 5591505 into openzfs:master Sep 29, 2024
13 of 14 checks passed
@gmelikov gmelikov deleted the zfsprops_recordsize branch September 29, 2024 21:15
Comment on lines +1540 to +1542
Note that maximum size is still limited by default to
.Ar 1 MiB
on x86_32, see
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formally it is any 32-bit, not necessary x86.

ptr1337 pushed a commit to CachyOS/zfs that referenced this pull request Nov 14, 2024
Reflect openzfs@f2330bd
change in our man pages and add some context.

Wording is primarily copy-pasted from code comments.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by:  Tino Reichardt <milky-zfs@mcmilk.de>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes openzfs#16581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants