-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: cancel workflows when PRs are updated #16562
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
added
Component: Test Suite
Indicates an issue with the test framework or a test case
Status: Code Review Needed
Ready for review and testing
labels
Sep 24, 2024
behlendorf
force-pushed
the
zts-concurrency
branch
from
September 24, 2024 00:09
20b472c
to
d6c145a
Compare
behlendorf
force-pushed
the
zts-concurrency
branch
from
September 24, 2024 00:35
d6c145a
to
64cd16a
Compare
behlendorf
added a commit
to behlendorf/zfs
that referenced
this pull request
Sep 24, 2024
For zloop, zfs-qemu, and codeql workflows cancel in-progress jobs when the PR is updated. We always let the style checker run since it only takes a few minutes to complete. Relevant GitHub Actions documentation: The following concurrency group cancels in-progress jobs or run on pull_request events only; if github.head_ref is undefined, the concurrency group will fallback to the run ID, which is guaranteed to be both unique and defined for the run. https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-using-a-fallback-value Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue openzfs#16562
behlendorf
force-pushed
the
zts-concurrency
branch
from
September 24, 2024 00:47
64cd16a
to
0e292b5
Compare
behlendorf
added a commit
to behlendorf/zfs
that referenced
this pull request
Sep 24, 2024
For zloop, zfs-qemu, and codeql workflows cancel in-progress jobs when the PR is updated. We always let the style checker run since it only takes a few minutes to complete. Relevant GitHub Actions documentation: The following concurrency group cancels in-progress jobs or run on pull_request events only; if github.head_ref is undefined, the concurrency group will fallback to the run ID, which is guaranteed to be both unique and defined for the run. https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-using-a-fallback-value Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue openzfs#16562
behlendorf
force-pushed
the
zts-concurrency
branch
from
September 24, 2024 05:15
0e292b5
to
d9f3d26
Compare
For checkstyle, zloop, zfs-qemu, and codeql workflows cancel in-progress jobs when the PR is updated. Relevant GitHub Actions documentation: The following concurrency group cancels in-progress jobs or run on pull_request events only; if github.head_ref is undefined, the concurrency group will fallback to the run ID, which is guaranteed to be both unique and defined for the run. https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-using-a-fallback-value Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue openzfs#16562
behlendorf
force-pushed
the
zts-concurrency
branch
from
September 24, 2024 15:44
d9f3d26
to
e2f1c25
Compare
behlendorf
added
Status: Accepted
Ready to integrate (reviewed, tested)
and removed
Status: Code Review Needed
Ready for review and testing
labels
Sep 24, 2024
robn
pushed a commit
to robn/zfs
that referenced
this pull request
Nov 5, 2024
For checkstyle, zloop, zfs-qemu, and codeql workflows cancel in-progress jobs when the PR is updated. Relevant GitHub Actions documentation: The following concurrency group cancels in-progress jobs or run on pull_request events only; if github.head_ref is undefined, the concurrency group will fallback to the run ID, which is guaranteed to be both unique and defined for the run. https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-using-a-fallback-value Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#16562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Test Suite
Indicates an issue with the test framework or a test case
Status: Accepted
Ready to integrate (reviewed, tested)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We want to cancel in-progress workflows for PRs which are updated to ensure the workers are testing useful changes. At the same time we always want to fully test changes which are merged to a branch.
@mcmilk @rincebrain I think this should handle the case mentioned in #16537 (comment).
Description
For checkstyle, zloop, zfs-qemu, and codeql workflows cancel in-progress jobs when the PR is updated.
Directly from GitHub Actions documentation:
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-using-a-fallback-value
How Has This Been Tested?
It hasn't. This is change is solely based on the example in the GitHub documentation.
Types of changes