Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZTS: add Ubuntu 20.04, 22.04 and 24.04 to the QEMU tests #16549

Closed
wants to merge 2 commits into from

Conversation

mcmilk
Copy link
Contributor

@mcmilk mcmilk commented Sep 19, 2024

ZTS: Remove functional tests via matrix

This commit changes the workflow of the github actions.

  • Ubuntu 20.04, 22.04, 24.04 will be tested via QEMU now
  • remove unused scripts of this commit: b7bc334
  • re-add the zloop standalone testings via zloop.yml

Signed-off-by: Tino Reichardt milky-zfs@mcmilk.de

Context

One queue run should complete in around 4h:

14x QEMU tests
1x Checkstyle
1x CodeQL
1x Zloop
sum: 17x ~ 3h 20m (we have 20 free runnners)

We may limit pull requests to maybe sth. like this:

  • AlmaLinux 8
  • AlmaLinux 9
  • FreeBSD 13 STABLE
  • FreeBSD 14 STABLE
  • Ubuntu 22.04

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Fix that error: "cat /tmp/failed.txt: No such file or directory"

Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
This commit changes the workflow of the github actions.

- Ubuntu 20.04, 22.04, 24.04 will be tested via QEMU now
- remove unused scripts of this commit: b7bc334
- re-add the zloop standalone testings via zloop.yml

Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Sep 19, 2024
@Harry-Chen
Copy link
Contributor

We may limit pull requests to maybe sth.

After searching I found this (in Chinese, but reading the yaml is enough): https://rudeigerc.dev/posts/github-actions-dynamic-matrices/

Basically we need a step to generate the matrix variable before actually running.

@mcmilk
Copy link
Contributor Author

mcmilk commented Sep 20, 2024

We may limit pull requests to maybe sth.

After searching I found this (in Chinese, but reading the yaml is enough): https://rudeigerc.dev/posts/github-actions-dynamic-matrices/

Basically we need a step to generate the matrix variable before actually running.

I had an idea of it, but this describes it perfectly. Thanks for that pointer.

behlendorf pushed a commit that referenced this pull request Sep 20, 2024
This commit changes the workflow of the github actions.

- Ubuntu 20.04, 22.04, 24.04 will be tested via QEMU now
- remove unused scripts of this commit: b7bc334
- re-add the zloop standalone testings via zloop.yml

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes #16549
mcmilk added a commit to mcmilk/zfs that referenced this pull request Sep 20, 2024
Fix that error: "cat /tmp/failed.txt: No such file or directory"

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#16549
mcmilk added a commit to mcmilk/zfs that referenced this pull request Sep 20, 2024
This commit changes the workflow of the github actions.

- Ubuntu 20.04, 22.04, 24.04 will be tested via QEMU now
- remove unused scripts of this commit: b7bc334
- re-add the zloop standalone testings via zloop.yml

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#16549
mcmilk added a commit to mcmilk/zfs that referenced this pull request Sep 20, 2024
Fix that error: "cat /tmp/failed.txt: No such file or directory"

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#16549
mcmilk added a commit to mcmilk/zfs that referenced this pull request Sep 20, 2024
This commit changes the workflow of the github actions.

- Ubuntu 20.04, 22.04, 24.04 will be tested via QEMU now
- remove unused scripts of this commit: b7bc334
- re-add the zloop standalone testings via zloop.yml

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#16549
mcmilk added a commit to mcmilk/zfs that referenced this pull request Sep 21, 2024
Fix that error: "cat /tmp/failed.txt: No such file or directory"

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#16549
mcmilk added a commit to mcmilk/zfs that referenced this pull request Sep 21, 2024
This commit changes the workflow of the github actions.

- Ubuntu 20.04, 22.04, 24.04 will be tested via QEMU now
- remove unused scripts of this commit: b7bc334
- re-add the zloop standalone testings via zloop.yml

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#16549
@mcmilk mcmilk deleted the zts-ubuntu branch September 21, 2024 08:02
robn pushed a commit to robn/zfs that referenced this pull request Nov 5, 2024
Fix that error: "cat /tmp/failed.txt: No such file or directory"

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#16549
robn pushed a commit to robn/zfs that referenced this pull request Nov 5, 2024
This commit changes the workflow of the github actions.

- Ubuntu 20.04, 22.04, 24.04 will be tested via QEMU now
- remove unused scripts of this commit: b7bc334
- re-add the zloop standalone testings via zloop.yml

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes openzfs#16549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants