Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issig() to check signal_pending after dequeue SIGSTOP/SIGTSTP #16464

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix issig() to check signal_pending after dequeue SIGSTOP/SIGTSTP #16464

merged 1 commit into from
Aug 27, 2024

Conversation

jsai20
Copy link
Contributor

@jsai20 jsai20 commented Aug 21, 2024

When process got SIGSTOP/SIGTSTP, issig() dequeue them and return 0. But process could still have another signal pending after dequeue. So, after dequeue, check and return 1, if signal_pending.

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@jsai20
Fix issig() to check signal_pending after dequeue SIGSTOP/SIGTSTP
0d291cb 
When process got SIGSTOP/SIGTSTP, issig() dequeue them and return 0.
But process could still have another signal pending after dequeue. So,
after dequeue, check and return 1, if signal_pending.

Signed-off-by: Jitendra Patidar <jitendra.patidar@nutanix.com>
@behlendorf behlendorf requested a review from pcd1193182 August 21, 2024 15:07
@behlendorf behlendorf added Status: Code Review Needed Ready for review and testing Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 21, 2024
@behlendorf behlendorf merged commit 73866cf into openzfs:master Aug 27, 2024
22 of 23 checks passed
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
@jsai20 @lundman
Fix issig() to check signal_pending after dequeue SIGSTOP/SIGTSTP
6efd375 
When process got SIGSTOP/SIGTSTP, issig() dequeue them and return 0.
But process could still have another signal pending after dequeue. So,
after dequeue, check and return 1, if signal_pending.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Jitendra Patidar <jitendra.patidar@nutanix.com>
Closes openzfs#16464
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
@jsai20 @lundman
Fix issig() to check signal_pending after dequeue SIGSTOP/SIGTSTP
c670b6a 
When process got SIGSTOP/SIGTSTP, issig() dequeue them and return 0.
But process could still have another signal pending after dequeue. So,
after dequeue, check and return 1, if signal_pending.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Jitendra Patidar <jitendra.patidar@nutanix.com>
Closes openzfs#16464
ptr1337 pushed a commit to CachyOS/zfs that referenced this pull request Nov 14, 2024
@jsai20 @tonyhutter
Fix issig() to check signal_pending after dequeue SIGSTOP/SIGTSTP
958838f 
When process got SIGSTOP/SIGTSTP, issig() dequeue them and return 0.
But process could still have another signal pending after dequeue. So,
after dequeue, check and return 1, if signal_pending.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Jitendra Patidar <jitendra.patidar@nutanix.com>
Closes openzfs#16464
ptr1337 pushed a commit to CachyOS/zfs that referenced this pull request Nov 21, 2024
@jsai20 @tonyhutter
Fix issig() to check signal_pending after dequeue SIGSTOP/SIGTSTP
f6fce8e 
When process got SIGSTOP/SIGTSTP, issig() dequeue them and return 0.
But process could still have another signal pending after dequeue. So,
after dequeue, check and return 1, if signal_pending.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Jitendra Patidar <jitendra.patidar@nutanix.com>
Closes openzfs#16464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@pcd1193182 pcd1193182 Awaiting requested review from pcd1193182

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsai20 @behlendorf