-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeBSD: remove support for FreeBSD < 13.0-RELEASE #16372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. It is a big cleanup. The chosen 13.0-RELEASE point choice is logical, since it is when 13-CURRENT turned into 13-STABLE which symbolizes less volatile APIs/KPIs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - it's needed I think 👍
This includes the last 12.x release (now EOL) and 13.0 development versions (<1300139). Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <robn@despairlabs.com>
f57fb5d
to
fcbdb0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm this builds on 13.3-STABLE, 14.1-STABLE, and 15.0-CURRENT.
Thanks all! |
This includes the last 12.x release (now EOL) and 13.0 development versions (<1300139). Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <robn@despairlabs.com> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Reviewed-by: Tony Hutter <hutter2@llnl.gov>
This includes the last 12.x release (now EOL) and 13.0 development versions (<1300139). Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <robn@despairlabs.com> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Reviewed-by: Tony Hutter <hutter2@llnl.gov>
This includes the last 12.x release (now EOL) and 13.0 development versions (<1300139). Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <robn@despairlabs.com> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Motivation and Context
I was doing some refactoring in some FreeBSD platform code, and had reason to look at when a particular kernel API was introduced. Then I noticed that 12.x didn't have the thing I was looking for, but also as of 2023-12-31 12.x is EOL and you can't even easily construct a new 12.x system, so I couldn't even see if OpenZFS compiles on it. Given we don't really know if it works, and probably everyone has upgraded, and it shipped the old pre 2.0/ZoL ZFS, I figure there's approximately zero people in the world that run OpenZFS 2.2+ on FreeBSD 12.x, and we can drop support for it.
Description
The first 13.0-RELEASE was
__FreeBSD_version
was1300139
, so for every check for a version on or before this, remove the "previous" code.This allows some macro cleanup as well, where macros existed just to map old things to new ones.
Then, bump README.
Note that while technically everything before 13.3-RELEASE is EOL (since 2024-06-30), support for that is limited to a single check (
vn_lock_pair()
args inzfs_freebsd_copy_file_range()
) and removing it just feels petty, so I did not,How Has This Been Tested?
Compile checked on FreeBSD 13.2-RELEASE-p12, 13.3-RELEASE-p3, 14.1-RELEASE.
(more than ever before, I need to set up a ZTS rig for FreeBSD).
Types of changes
Checklist:
Signed-off-by
.