Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD: remove support for FreeBSD < 13.0-RELEASE #16372

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

robn
Copy link
Member

@robn robn commented Jul 21, 2024

Motivation and Context

I was doing some refactoring in some FreeBSD platform code, and had reason to look at when a particular kernel API was introduced. Then I noticed that 12.x didn't have the thing I was looking for, but also as of 2023-12-31 12.x is EOL and you can't even easily construct a new 12.x system, so I couldn't even see if OpenZFS compiles on it. Given we don't really know if it works, and probably everyone has upgraded, and it shipped the old pre 2.0/ZoL ZFS, I figure there's approximately zero people in the world that run OpenZFS 2.2+ on FreeBSD 12.x, and we can drop support for it.

Description

The first 13.0-RELEASE was __FreeBSD_version was 1300139, so for every check for a version on or before this, remove the "previous" code.

This allows some macro cleanup as well, where macros existed just to map old things to new ones.

Then, bump README.

Note that while technically everything before 13.3-RELEASE is EOL (since 2024-06-30), support for that is limited to a single check (vn_lock_pair() args in zfs_freebsd_copy_file_range()) and removing it just feels petty, so I did not,

How Has This Been Tested?

Compile checked on FreeBSD 13.2-RELEASE-p12, 13.3-RELEASE-p3, 14.1-RELEASE.

(more than ever before, I need to set up a ZTS rig for FreeBSD).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. It is a big cleanup. The chosen 13.0-RELEASE point choice is logical, since it is when 13-CURRENT turned into 13-STABLE which symbolizes less volatile APIs/KPIs.

Copy link
Contributor

@mcmilk mcmilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - it's needed I think 👍

This includes the last 12.x release (now EOL) and 13.0 development
versions (<1300139).

Sponsored-by: https://despairlabs.com/sponsor/
Signed-off-by: Rob Norris <robn@despairlabs.com>
@robn robn force-pushed the remove-freebsd-pre-13 branch from f57fb5d to fcbdb0f Compare July 26, 2024 01:29
Copy link
Contributor

@tonyhutter tonyhutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this builds on 13.3-STABLE, 14.1-STABLE, and 15.0-CURRENT.

@tonyhutter tonyhutter merged commit 6c82951 into openzfs:master Aug 5, 2024
20 of 24 checks passed
@robn
Copy link
Member Author

robn commented Aug 6, 2024

Thanks all!

lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
This includes the last 12.x release (now EOL) and 13.0 development
versions (<1300139).

Sponsored-by: https://despairlabs.com/sponsor/

Signed-off-by: Rob Norris <robn@despairlabs.com>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
ptr1337 pushed a commit to CachyOS/zfs that referenced this pull request Nov 14, 2024
This includes the last 12.x release (now EOL) and 13.0 development
versions (<1300139).

Sponsored-by: https://despairlabs.com/sponsor/

Signed-off-by: Rob Norris <robn@despairlabs.com>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
ptr1337 pushed a commit to CachyOS/zfs that referenced this pull request Nov 21, 2024
This includes the last 12.x release (now EOL) and 13.0 development
versions (<1300139).

Sponsored-by: https://despairlabs.com/sponsor/

Signed-off-by: Rob Norris <robn@despairlabs.com>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants